fix bug in test / the test should have failed before

Author: snazy

runtime/service/src/intTest/java/org/apache/polaris/service/it/RestCatalogMinIOSpecialIT.java

@@ -30,6 +30,7 @@
 import io.quarkus.test.junit.TestProfile;
 import java.io.IOException;
 import java.io.InputStream;
+import java.net.InetAddress;
 import java.net.URI;
 import java.util.List;
 import java.util.Map;
@@ -223,19 +224,24 @@ public void testCreateTable(boolean pathStyle) throws IOException {
   }
 
   @Test
-  public void testInternalEndpoints() throws IOException {
+  public void testInternalEndpoints() throws Exception {
+    // Note: this test passed "before", although it should have always failed, because
+    // 's3.example.com' cannot be resolved.
+
+    // Here, we replace 'localhost' with the IP address.
+    var uri = URI.create(endpoint);
+    var address = InetAddress.getByName(uri.getHost()).getHostAddress();
+    var endpointByAddress =
+        new URI(uri.getScheme(), null, address, uri.getPort(), "/", null, null).toString();
     try (RESTCatalog restCatalog =
         createCatalog(
-            Optional.of("http://s3.example.com"),
-            Optional.of(endpoint),
-            false,
-            Optional.of(endpoint))) {
+            Optional.of(endpointByAddress), Optional.of(endpoint), false, Optional.of(endpoint))) {
       LoadTableResponse loadTableResponse = doTestCreateTable(restCatalog);
-      assertThat(loadTableResponse.config()).containsEntry("s3.endpoint", "http://s3.example.com");
+      assertThat(loadTableResponse.config()).containsEntry("s3.endpoint", endpointByAddress);
     }
   }
 
-  public LoadTableResponse doTestCreateTable(RESTCatalog restCatalog) throws IOException {
+  public LoadTableResponse doTestCreateTable(RESTCatalog restCatalog) {
     catalogApi.createNamespace(catalogName, "test-ns");
     TableIdentifier id = TableIdentifier.of("test-ns", "t1");
     Table table = restCatalog.createTable(id, SCHEMA);