From 4d2daa2120a7c18edb7f87ddcb6bad32e4258b4d Mon Sep 17 00:00:00 2001
From: Alexandre Dutra <adutra@apache.org>
Date: Thu, 7 Aug 2025 17:06:33 +0200
Subject: [PATCH] Remove unused LIST_PAGINATION_ENABLED feature configuration

---
 CHANGELOG.md                                              | 2 ++
 .../it/test/PolarisRestCatalogIntegrationBase.java        | 3 +--
 .../apache/polaris/core/config/FeatureConfiguration.java  | 8 --------
 .../service/catalog/AbstractIcebergCatalogTest.java       | 1 -
 .../service/catalog/AbstractIcebergCatalogViewTest.java   | 1 -
 5 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 108eb00044..c6453b8285 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -31,6 +31,8 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
 
 ### Upgrade notes
 
+- The `LIST_PAGINATION_ENABLED` feature configuration was unused and has been removed.
+
 ### Breaking changes
 
 - Helm chart: the default value of the `authentication.tokenBroker.secret.symmetricKey.secretKey` property has changed
diff --git a/integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationBase.java b/integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationBase.java
index c8400e5baf..02f4e880e8 100644
--- a/integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationBase.java
+++ b/integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationBase.java
@@ -164,8 +164,7 @@ public abstract class PolarisRestCatalogIntegrationBase extends CatalogTests<RES
 
   private static final String[] DEFAULT_CATALOG_PROPERTIES = {
     "polaris.config.allow.unstructured.table.location", "true",
-    "polaris.config.allow.external.table.location", "true",
-    "polaris.config.list-pagination-enabled", "true"
+    "polaris.config.allow.external.table.location", "true"
   };
 
   @Retention(RetentionPolicy.RUNTIME)
diff --git a/polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java b/polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java
index 05b7e0dec3..379ffe81b2 100644
--- a/polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java
+++ b/polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java
@@ -219,14 +219,6 @@ public static void enforceFeatureEnabledOrThrow(
           .defaultValue(2)
           .buildFeatureConfiguration();
 
-  public static final PolarisConfiguration<Boolean> LIST_PAGINATION_ENABLED =
-      PolarisConfiguration.<Boolean>builder()
-          .key("LIST_PAGINATION_ENABLED")
-          .catalogConfig("polaris.config.list-pagination-enabled")
-          .description("If set to true, pagination for APIs like listTables is enabled.")
-          .defaultValue(false)
-          .buildFeatureConfiguration();
-
   public static final FeatureConfiguration<Boolean> ENABLE_GENERIC_TABLES =
       PolarisConfiguration.<Boolean>builder()
           .key("ENABLE_GENERIC_TABLES")
diff --git a/runtime/service/src/test/java/org/apache/polaris/service/catalog/AbstractIcebergCatalogTest.java b/runtime/service/src/test/java/org/apache/polaris/service/catalog/AbstractIcebergCatalogTest.java
index b37447616a..9f6c8625b7 100644
--- a/runtime/service/src/test/java/org/apache/polaris/service/catalog/AbstractIcebergCatalogTest.java
+++ b/runtime/service/src/test/java/org/apache/polaris/service/catalog/AbstractIcebergCatalogTest.java
@@ -196,7 +196,6 @@ public Map<String, String> getConfigOverrides() {
       return ImmutableMap.<String, String>builder()
           .putAll(super.getConfigOverrides())
           .put("polaris.features.\"ALLOW_TABLE_LOCATION_OVERLAP\"", "true")
-          .put("polaris.features.\"LIST_PAGINATION_ENABLED\"", "true")
           .build();
     }
   }
diff --git a/runtime/service/src/test/java/org/apache/polaris/service/catalog/AbstractIcebergCatalogViewTest.java b/runtime/service/src/test/java/org/apache/polaris/service/catalog/AbstractIcebergCatalogViewTest.java
index b7ad589300..12cb3bd178 100644
--- a/runtime/service/src/test/java/org/apache/polaris/service/catalog/AbstractIcebergCatalogViewTest.java
+++ b/runtime/service/src/test/java/org/apache/polaris/service/catalog/AbstractIcebergCatalogViewTest.java
@@ -90,7 +90,6 @@ public Map<String, String> getConfigOverrides() {
           .putAll(super.getConfigOverrides())
           .put("polaris.features.\"ALLOW_WILDCARD_LOCATION\"", "true")
           .put("polaris.features.\"SKIP_CREDENTIAL_SUBSCOPING_INDIRECTION\"", "true")
-          .put("polaris.features.\"LIST_PAGINATION_ENABLED\"", "true")
           .build();
     }
   }