[Bug] run ginkgo -race -repeat=5 ./bydbctl/internal/cmd/... failed

[OmCheeLin]

Search before asking

• I had searched in the issues and found no similar issues.

Apache SkyWalking Component

BanyanDB (apache/skywalking-banyandb)

What happened

run cmd ginkgo -race -repeat=5 ./bydbctl/internal/cmd/... then failed
Is this normal?

------------------------------
• [FAILED] [2.060 seconds]
Property Schema Operation [It] list property schema
/data/wangyi/skywalking-banyandb/bydbctl/internal/cmd/property_test.go:341

  [FAILED] Unexpected error:
      <*errors.errorString | 0xc0075cd040>: 
      yaml: mapping values are not allowed in this context
      {
          s: "yaml: mapping values are not allowed in this context",
      }
  occurred
  In [It] at: /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58 @ 04/22/26 22:20:54.286
------------------------------

Summarizing 62 Failures:
  [FAIL] Stream Data Query [It] query stream all data
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Stream Data Query query stream data with time range flags [It] relative start
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Stream Data Query query stream data with time range flags [It] relative end
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Stream Data Query query stream data with time range flags [It] absolute start
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Stream Data Query query stream data with time range flags [It] absolute end
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Stream Data Query query stream data with time range flags [It] default
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Stream Data Query query stream data with time range flags [It] all relative
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Stream Data Query query stream data with time range flags [It] all absolute
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Stream Schema Operation [It] get stream schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Stream Schema Operation [It] update stream schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Stream Schema Operation [It] list stream schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Trace Schema Operation [It] get trace schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Trace Schema Operation [It] update trace schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Trace Schema Operation [It] list trace schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Group [It] get group
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Group [It] list group
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] IndexRuleBindingSchema Operation [It] get indexRuleBinding schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] IndexRuleBindingSchema Operation [It] update indexRuleBinding schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] IndexRuleBindingSchema Operation [It] list indexRuleBinding schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] IndexRuleSchema Operation [It] get indexRule schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] IndexRuleSchema Operation [It] update indexRule schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] IndexRuleSchema Operation [It] list indexRule schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Trace Data Query [It] query trace all data
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Trace Data Query query trace data with time range flags [It] relative start
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Trace Data Query query trace data with time range flags [It] relative end
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Trace Data Query query trace data with time range flags [It] absolute start
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Trace Data Query query trace data with time range flags [It] absolute end
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Trace Data Query query trace data with time range flags [It] default
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Trace Data Query query trace data with time range flags [It] all relative
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Trace Data Query query trace data with time range flags [It] all absolute
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Property Cluster Resilience with 5 Data Nodes [It] should handle node failures and repairs correctly
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Measure Data Query [It] query all measure data
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Measure Data Query query measure data with time range flags [It] relative start
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Measure Data Query query measure data with time range flags [It] relative end
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Measure Data Query query measure data with time range flags [It] absolute start
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Measure Data Query query measure data with time range flags [It] absolute end
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Measure Data Query query measure data with time range flags [It] default
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Measure Data Query query measure data with time range flags [It] all relative
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Measure Data Query query measure data with time range flags [It] all absolute
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Property Cluster background Repair Operation [It] Repair with tracing
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Property Operation [It] update property
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Property Operation [It] query all properties
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Property Operation [It] delete property
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Property Cluster Operation [BeforeEach] query from difference version
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Property Cluster Operation [BeforeEach] delete property
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Topn Schema Operation [It] get topn schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Topn Schema Operation [It] update topn schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Topn Schema Operation [It] list topn schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Measure Schema Operation [It] get measure schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Measure Schema Operation [It] update measure schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Measure Schema Operation [It] list measure schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Topn Data Query [It] query all topn data
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Topn Data Query query topn data with time range flags [It] relative start
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Topn Data Query query topn data with time range flags [It] relative end
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Topn Data Query query topn data with time range flags [It] absolute start
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Topn Data Query query topn data with time range flags [It] absolute end
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Topn Data Query query topn data with time range flags [It] default
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Topn Data Query query topn data with time range flags [It] all relative
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Topn Data Query query topn data with time range flags [It] all absolute
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Property Schema Operation [It] get property schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Property Schema Operation [It] update property schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58
  [FAIL] Property Schema Operation [It] list property schema
  /data/wangyi/skywalking-banyandb/pkg/test/helpers/constant.go:58

Ran 88 of 88 Specs in 249.619 seconds
FAIL! -- 26 Passed | 62 Failed | 0 Pending | 0 Skipped
--- FAIL: TestCmd (249.63s)
    testing.go:1617: race detected during execution of test
FAIL

Ginkgo ran 1 suite in 4m10.73516865s

Test Suite Failed

What you expected to happen

test success

How to reproduce

run ginkgo -race -repeat=5 ./bydbctl/internal/cmd/...

Anything else

No response

Are you willing to submit a pull request to fix on your own?

• Yes I am willing to submit a pull request on my own!

Code of Conduct

• I agree to follow this project's Code of Conduct

[paultanay]

Thanks for the detailed report. I tried to narrow it down locally on apache/skywalking-banyandb at 4529ca3b.

I can reproduce a real race-sensitive failure with the bydbctl command tests under -race. From the stacks I saw, this looks less like 62 independent bydbctl/product failures and more like a test harness/output-capture problem:

• the bydbctl tests use go-capturer.CaptureStdout, which temporarily swaps the process-global os.Stdout;
• the embedded BanyanDB test nodes are still logging in background goroutines;
• zerolog’s console writer checks the global os.Stdout/os.Stderr while writing;
• several tests then parse captured command output as YAML, so corrupted or unstable captured output can surface as yaml: mapping values are not allowed in this context.

One important nuance: the CI path seems different from the raw command in this issue. make test-ci sets pkg/test/flags.LogLevel=error, while the local default is debug, so this may not currently be CI-blocking. But I agree the issue is real as a race-sensitive test-quality problem.

I think the clean fix direction is to avoid global stdout capture in these Cobra command tests. The tests should capture command-local output buffers instead of mutating process stdout, or otherwise make the embedded test runtime logging safe for -race while stdout is being captured.