d3 formatting not working

[duffar12]

Expected results

Number formatting on dashboard should change according to d3 format specified in metrics

Actual results

Specifying a d3 format works on the COUNT(*) metric. But has no affect on any other metric as far as I can tell

Screenshots

In the image above COUNT(*) and SUM(count) have the same d3 format configured. However, the configuration is not being applied to SUM(count)

How to reproduce the bug

1. Change the d3 format of COUNT(*) and any other metric for one of your tables
2. Create a table view of these two metrics.
3. Notice that d3 formatting is only applied to the COUNT(*) metric

Environment

*superset version: 0.33.0
*python version: 3.6.8

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

I have seen a number of other Issues raised around d3 formatting dating back to 2017. As far as I can tell those issues were fixed in this PR #2598
So I believe this must be a new bug

[issue-label-bot]

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.91. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[duffar12]

@kristw any ideas about how to fix this?

[Orchild]

Same problem on Pie Chart, D3 Format not work

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[crazyplum]

@kristw
same issues here.
please don't close this issue.

[rusackas]

FWIW, I managed to get D3 formatting to work in the Table component for other metrics besides COUNT(*) as you can see in this (admittedly odd looking) example:

Nonetheless, I also see/confirm that this formatting value is not represented in the Pie chart (or probably other NVD3-derived chart types).

[kristw]

@rusackas There is an incomplete PR, which maybe related, if anybody feels like picking up.
apache-superset/superset-ui-plugins#171

[rusackas]

PRs to respect the metrics' D3 Format value submitted here:
apache-superset/superset-ui-plugins#280
and here:
apache-superset/superset-ui-plugins#282