Disallow mutation option in mutate callback returned from useMutation (#12802)

Author: jerelmiller

.api-reports/api-report-react.api.md

@@ -632,9 +632,7 @@ export namespace useMutation {
     }
     ]) => Promise<ApolloClient.MutateResult<MaybeMasked<TData>>>;
     // (undocumented)
-    export type MutationFunctionOptions<TData = unknown, TVariables extends OperationVariables = OperationVariables, TCache extends ApolloCache = ApolloCache> = Options<TData, TVariables, TCache> & {
-        mutation?: DocumentNode_2 | TypedDocumentNode<TData, TVariables>;
-    };
+    export type MutationFunctionOptions<TData = unknown, TVariables extends OperationVariables = OperationVariables, TCache extends ApolloCache = ApolloCache> = Options<TData, TVariables, TCache>;
     // (undocumented)
     export interface Options<TData = unknown, TVariables extends OperationVariables = OperationVariables, TCache extends ApolloCache = ApolloCache, TConfiguredVariables extends Partial<TVariables> = Partial<TVariables>> {
         awaitRefetchQueries?: boolean;

.changeset/heavy-ways-call.md

@@ -0,0 +1,5 @@
+---
+"@apollo/client": major
+---
+
+Disallow the `mutation` option for the `mutate` function returned from `useMutation`.

src/react/hooks/useMutation.ts

@@ -157,12 +157,7 @@ export declare namespace useMutation {
     TData = unknown,
     TVariables extends OperationVariables = OperationVariables,
     TCache extends ApolloCache = ApolloCache,
-  > = Options<TData, TVariables, TCache> & {
-    /** {@inheritDoc @apollo/client!MutationOptionsDocumentation#mutation:member} */
-    // TODO: Remove this option. We shouldn't allow the mutation to be overridden
-    // in the mutation function
-    mutation?: DocumentNode | TypedDocumentNode<TData, TVariables>;
-  };
+  > = Options<TData, TVariables, TCache>;
 
   export namespace DocumentationTypes {
     /** {@inheritDoc @apollo/client!useMutation:function(1)} */