InMemoryCache: store fields with an empty object of optional arguments the same as fields without arguments

[phryneas]

Fixes #12365
Fixes #8853

[changeset-bot]

🦋 Changeset detected

Latest commit: 40599b3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[svc-apollo-docs]

❌ Docs preview failed

The preview failed to build.

Build ID: da8a08760232a3773e0b2cce

Errors

react/data/subscriptions

• Cannot find module '@microsoft/tsdoc/schemas/tsdoc.schema.json' from '/var/task/node_modules/.pnpm/@microsoft[email protected]/node_modules/@microsoft/tsdoc-config/lib'

[pkg-pr-new]

npm i https://pkg.pr.new/apollographql/apollo-client/@apollo/client@12370

commit: 40599b3

[netlify]

✅ Deploy Preview for apollo-client-docs ready!

Name	Link
🔨 Latest commit	3ca1179
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/67cfff39a8a682000872d98a
😎 Deploy Preview	https://deploy-preview-12370--apollo-client-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

size-limit report 📦

Path	Size
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (CJS)	42.81 KB (+0.11% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) (CJS)	37.92 KB (-0.05% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client"	32.67 KB (+0.09% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production)	27.1 KB (+0.29% 🔺)
import { ApolloProvider } from "@apollo/client/react"	5.7 KB (0%)
import { ApolloProvider } from "@apollo/client/react" (production)	960 B (0%)
import { useQuery } from "@apollo/client/react"	6.99 KB (0%)
import { useQuery } from "@apollo/client/react" (production)	2.23 KB (0%)
import { useLazyQuery } from "@apollo/client/react"	6.88 KB (0%)
import { useLazyQuery } from "@apollo/client/react" (production)	2.13 KB (0%)
import { useMutation } from "@apollo/client/react"	6.22 KB (0%)
import { useMutation } from "@apollo/client/react" (production)	1.48 KB (0%)
import { useSubscription } from "@apollo/client/react"	6.57 KB (0%)
import { useSubscription } from "@apollo/client/react" (production)	1.81 KB (0%)
import { useSuspenseQuery } from "@apollo/client/react"	8.34 KB (0%)
import { useSuspenseQuery } from "@apollo/client/react" (production)	3.62 KB (0%)
import { useBackgroundQuery } from "@apollo/client/react"	8.13 KB (0%)
import { useBackgroundQuery } from "@apollo/client/react" (production)	3.38 KB (0%)
import { useLoadableQuery } from "@apollo/client/react"	8.07 KB (0%)
import { useLoadableQuery } from "@apollo/client/react" (production)	3.36 KB (0%)
import { useReadQuery } from "@apollo/client/react"	6.37 KB (0%)
import { useReadQuery } from "@apollo/client/react" (production)	1.62 KB (0%)
import { useFragment } from "@apollo/client/react"	6.45 KB (0%)
import { useFragment } from "@apollo/client/react" (production)	1.69 KB (0%)

[phryneas]

I've opted to add exact only to our internal api and not expose it.
Userland code can still compare the storeFieldName and fieldName values passed into the modifier function to reach this goal, and we should probably not encourage people to write code like

cache.modify(id, {
  fields: {
    ['myField({"complex":....})']() {
      /* ... */
    },
  },
});

in the first place.
There is would be slightly more sane to use

cache.modify(id, {
  fields: {
    myField(value, { storeFieldName }) {
      if (storeFieldName === 'myField({"complex":....})') {
        /* ... */
      }
    },
  },
});

instead.

[jerelmiller]

Looks good to me!

[apollo-librarian]

⚠️ Docs preview not attached to branch

The preview was not built because the PR's base branch release-4.0 is not in the list of sources.

An Apollo team member can comment one of the following commands to dictate which branch to attach the preview to:

• !docs set-base-branch version-2.6
• !docs set-base-branch main

Build ID: 64e287b93ce9880bd7b7da8f