Skip to content

Commit 5384448

Browse files
committed
add a comment about why join v0.3 for fed 2.0
1 parent b28555e commit 5384448

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

internals-js/src/specs/joinSpec.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,10 @@ export class JoinSpecDefinition extends FeatureDefinition {
287287
export const JOIN_VERSIONS = new FeatureDefinitions<JoinSpecDefinition>(joinIdentity)
288288
.add(new JoinSpecDefinition(new FeatureVersion(0, 1)))
289289
.add(new JoinSpecDefinition(new FeatureVersion(0, 2)))
290+
// Though join v0.2 supports federation v2.0 as mentioned above, we should
291+
// still prefer join v0.3 as a minimum for all of federation v2.0-2.6 since
292+
// v0.3 offers improvements around union members and enum values that we're
293+
// interested in.
290294
.add(new JoinSpecDefinition(new FeatureVersion(0, 3), new FeatureVersion(2, 0)))
291295
.add(new JoinSpecDefinition(new FeatureVersion(0, 4), new FeatureVersion(2, 7)))
292296
.add(new JoinSpecDefinition(new FeatureVersion(0, 5), new FeatureVersion(2, 8)));

0 commit comments

Comments
 (0)