-
Notifications
You must be signed in to change notification settings - Fork 324
1.x: Bump MSRV to Rust 1.88.0 for ecosystem compatibility #8640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.x
Are you sure you want to change the base?
Conversation
Moves MSRV from 1.85.0 to 1.88.0 — this keeps us positioned to pull in security and bug fix updates from the ecosystem without getting stuck. Already seeing deps like aws-sdk-sso, aws-sdk-ssooidc, and aws-sdk-sts requiring 1.88+, so this is about staying agile rather than responding to an immediate security issue. Also fixes a test compatibility issue with Rust 1.88.0's panic message formatting in caching_query_planner.rs — now uses starts_with() instead of exact string matching for forwards/backwards compatibility. No breaking changes for binary users — only affects library consumers.
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removedBuild ID: e1eb2bf454e6e99feac0130a URL: https://www.apollographql.com/docs/deploy-preview/e1eb2bf454e6e99feac0130a |
|
there's a few other places that reference the rust version, easiest to identify by: rg 'renovate-automation: rustc version' -A1 |
|
I did find more, after I pushed. |
|
ah, looks like there's some more I should look at, too. |
|
The lint failures for |
|
Yeah the clippy changes is why I wasn't sure whether to do this when I had a few-minute look last week. It's either that or recursively pinning dependency versions, which I'm not sure how to do, and might be a problem if there's a security issue in the future. Or I guess disabling lints, but shrug. The |
|
I did successfully recursively pin the dependencies, however, it was REALLY messy and left us on worryingly old versions of things. I'll look at clippy fixes. |
Detected SAST Vulnerabilities🔴 Potential Security Issues FoundIf you are seeing this message, it means that the security scanning tool that Apollo uses to test our source has identified a potential security issue in code introduced or updated via your branch. Information about what was detected and steps to move forward are below. If the scanner detected a legitimate issue, please take action to correct it prior to merging this PR. The action required will vary based on the detection. If the detection is a false positive, please follow the steps below to resolve the issue. Issues Detected
|
Moves MSRV from 1.85.0 to 1.88.0 — this keeps us positioned to pull in security and bug fix updates from the ecosystem without getting stuck. Not moving to Rust 1.91 (more current Rust) since this is a Maintenance LTS line and less changes seem preferable.
Already seeing deps like
aws-sdk-sso,aws-sdk-ssooidc, andaws-sdk-stsrequiring 1.88+, so this is about staying agile rather than responding to an immediate security issue.Necessarily fixes a test compatibility issue with Rust 1.88.0's panic message formatting in
caching_query_planner.rs— it now has to usestarts_with()instead of exact string matching.No breaking changes for binary users — only affects library consumers who need to update their Rust toolchain to 1.88.0+.
Changes
caching_query_planner.rstest for Rust 1.88.0 panic message format