Pin dependencies to maintain Rust 1.85.0 MSRV #8675
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pin several transitive dependencies to versions compatible with Rust 1.85.0 MSRV, preventing automatic upgrades that would require newer Rust versions. Pinned dependencies: - aws-config to 1.5.4 (prevents upgrade to 1.8+ requiring Rust 1.88) - aws-sdk-sso to 1.54.0 (MSRV 1.81.0) - aws-sdk-ssooidc to 1.55.0 (MSRV 1.81.0) - aws-sdk-sts to 1.55.0 (MSRV 1.81.0) - home to 0.5.9 (MSRV 1.70.0) - async-graphql/async-graphql-axum to 7.0.10 in fuzz subgraph (avoids 1.86+ requirement) Trade-offs: These pins are several releases behind latest (AWS SDK 1.54-1.55 vs 1.92+), reducing our ability to move to the tip. Work may become necessary to advance those.
Additional pins and fixes needed for test_updated CI job (which regenerates Cargo.lock): - Pin async-graphql transitive dependencies (derive, parser, value) to 7.0.10 to prevent cargo from resolving to incompatible newer versions - Pin apollo-smith to 0.15.0 (0.15.2+ uses unstable feature unsigned_is_multiple_of requiring Rust 1.87+) - Remove deprecated as_slice() calls on GenericArray (deprecated in generic-array 0.14.x) - Replace with hex::encode(digest.finalize()) where possible - Use explicit slice coercion &d[..] for other cases These changes ensure the codebase builds successfully even when Cargo.lock is regenerated from scratch with only Cargo.toml constraints.
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: ae5fed1b75119f5f0524f22b |
…aeger Additional AWS ecosystem pins required to maintain tokio 1.38.2 — newer AWS Smithy crates (aws-smithy-types 1.3+, aws-smithy-runtime-api 1.9+) force tokio >=1.40.0, which triggers runtime panic in opentelemetry-jaeger 0.19.0 due to stricter blocking fd restrictions (tokio-rs/tokio#7172). Pins applied: - aws-smithy-types to 1.2.12 (newer 1.3.x requires tokio ^1.40.0) - aws-smithy-runtime-api to 1.7.3 (1.9+ requires tokio ^1.40.0) - aws-smithy-async to 1.2.4 (maintains aws-sdk-sso compatibility) - async-compression to 0.4.11 (0.4.12+ requires tokio ^1.40.0) Adds Renovate grouping rule for aws-smithy-* and aws-sdk-* packages (similar to existing tracing/otel grouping) to prevent independent upgrades that break tokio compatibility. Resolves integration::lifecycle::test_reload_via_sighup failure discovered during testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pin several transitive dependencies to versions compatible with Rust 1.85.0 MSRV, preventing automatic upgrades that would require newer Rust versions.
Pinned dependencies
aws-configto1.5.4(prevents upgrade to 1.8+ which requires AWS SDK packages needing Rust 1.88)aws-sdk-ssoto1.54.0(MSRV 1.81.0)aws-sdk-ssooidcto1.55.0(MSRV 1.81.0)aws-sdk-ststo1.55.0(MSRV 1.81.0)hometo0.5.9(MSRV 1.70.0)async-graphql/async-graphql-axumto7.0.10in fuzz subgraph (avoids 1.86.0 requirement from 7.0.15+)async-graphql-derive,async-graphql-parser,async-graphql-valueto7.0.10(transitive deps must match to avoid macro incompatibilities)apollo-smithto0.15.0(0.15.2+ uses unstable featureunsigned_is_multiple_ofrequiring Rust 1.87+)Additional changes
as_slice()calls on GenericArray (deprecated in generic-array 0.14.x)hex::encode(digest.finalize())where possible&d[..]for other casesTrade-offs
These pins will secure the default experience of using this as a library, but may just delay future upgrades, including a full MSRV upgrade. The AWS SDK versions are several releases behind latest (1.54-1.55 vs 1.92+), though they still provide comfortable headroom above our MSRV (requiring only 1.81).
We can selectively bump to mid-range versions (e.g.,
aws-sdk-sso1.74.0) to narrow the gap while staying under any future MSRV increases, pending verification of functional compatibility.