xw - increase wait_until time when loading a page #195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is due to some flakey tests I found in my project.
In short, it's possible that
DocumentLoadertries to load an AePageObject document before the AePageObject document is ready, especially when the document takes more than 5 seconds to load Under such a circumstance, it throws an exception like below:To fix this issue, I set the default loading time to
10seconds whenDocumentLoadertries to load an AePageObject document. This change should be able to fix the most flakey tests (I'll be surprised if any page requires more than 10 seconds to load) and to avoid the similar flakey cases in the future.