Incorporate review feedback (more to follow later)

- use uri instead of response.uri()/redirected when constructing ResolvedModuleKey
- add docs for HttpClient implementations

Author: odenix

pkl-core/src/main/java/org/pkl/core/http/DummyHttpClient.java

@@ -20,6 +20,7 @@
 import java.net.http.HttpResponse.BodyHandler;
 import javax.annotation.concurrent.ThreadSafe;
 
+/** An {@code HttpClient} implementation that throws {@code AssertionError} on every send. */
 @ThreadSafe
 final class DummyHttpClient implements HttpClient {
   @Override

pkl-core/src/main/java/org/pkl/core/http/JdkHttpClient.java

@@ -51,6 +51,7 @@
 import org.pkl.core.util.ErrorMessages;
 import org.pkl.core.util.Exceptions;
 
+/** An {@code HttpClient} implementation backed by {@link java.net.http.HttpClient}. */
 @ThreadSafe
 final class JdkHttpClient implements HttpClient {
   // non-private for testing

pkl-core/src/main/java/org/pkl/core/http/LazyHttpClient.java

@@ -24,6 +24,11 @@
 import javax.annotation.concurrent.GuardedBy;
 import javax.annotation.concurrent.ThreadSafe;
 
+/**
+ * An {@code HttpClient} implementation that defers creating the underlying HTTP client until the
+ * first send. A potential drawback of using {@code LazyHttpClient} is that any {@link
+ * HttpClientInitException} thrown by the underlying client is equally deferred.
+ */
 @ThreadSafe
 class LazyHttpClient implements HttpClient {
   private final Supplier<HttpClient> supplier;

pkl-core/src/main/java/org/pkl/core/http/RequestRewritingClient.java

@@ -23,6 +23,18 @@
 import java.util.concurrent.atomic.AtomicBoolean;
 import javax.annotation.concurrent.ThreadSafe;
 
+/**
+ * An {@code HttpClient} decorator that
+ *
+ * <ul>
+ *   <li>overrides the {@code User-Agent} header of {@code HttpRequest}s
+ *   <li>sets a request timeout if none is present
+ *   <li>ensures that {@link #close()} is idempotent.
+ * </ul>
+ *
+ * <p>Both {@code User-Agent} header and default request timeout are configurable through {@link
+ * HttpClient.Builder}.
+ */
 @ThreadSafe
 final class RequestRewritingClient implements HttpClient {
   // non-private for testing

pkl-core/src/main/java/org/pkl/core/module/ModuleKeys.java

@@ -492,7 +492,8 @@ public ResolvedModuleKey resolve(SecurityManager securityManager)
           HttpUtils.checkHasStatusCode200(response);
           securityManager.checkResolveModule(response.uri());
           String text = IoUtils.readString(body);
-          return ResolvedModuleKeys.virtual(this, response.uri(), text, true);
+          // intentionally use uri instead of response.uri()
+          return ResolvedModuleKeys.virtual(this, uri, text, true);
         }
       }
 
@@ -509,7 +510,8 @@ public ResolvedModuleKey resolve(SecurityManager securityManager)
         }
         securityManager.checkResolveModule(redirected);
         var text = IoUtils.readString(stream);
-        return ResolvedModuleKeys.virtual(this, redirected, text, true);
+        // intentionally use uri instead of redirected
+        return ResolvedModuleKeys.virtual(this, uri, text, true);
       }
     }
   }