Fix invalid dashboards and add validation (#83)

These dashboards had an invalid combination of the `format` and
`format_input` fields. The `format_input` field only works with 'format
= size'.

Fix this by making them 'size' formats and add a
validation for it so this can't happen again.

Author: tombruijn

Rakefile

@@ -27,6 +27,7 @@ class Dashboard
       REQUIRED_VISUAL_FIELDS.each do |field|
         required_field(*visual_base, field)
       end
+      format_input_only_for_size(visual, visual_base)
 
       visual.fetch("metrics", []).each_with_index do |metric, metric_index|
         # Validate base metric fields
@@ -89,6 +90,18 @@ class Dashboard
     issues << "No '#{Array(field).join(".")}' field present"
   end
 
+  # The 'format_input' field declares the unit of an incoming size value. It is
+  # only used when the visual's 'format' is 'size'; the server unsets it for
+  # any other format on import.
+  def format_input_only_for_size(visual, visual_base)
+    return unless visual.key?("format_input")
+    return if visual["format"] == "size"
+
+    field = [*visual_base, "format_input"].join(".")
+    issues << "The '#{field}' field is only allowed when 'format' is 'size', " \
+      "but 'format' is #{visual["format"].inspect}"
+  end
+
   def dashboard
     definition["dashboard"]
   end

dashboards/aws/databases_rds.json

@@ -118,7 +118,7 @@
       {
         "type": "timeseries",
         "display": "line",
-        "format": "throughput",
+        "format": "size",
         "format_input": "byte",
         "draw_null_as_zero": true,
         "title": "Read Throughput vs Write Throughput",
@@ -173,7 +173,7 @@
       {
         "type": "timeseries",
         "display": "line",
-        "format": "throughput",
+        "format": "size",
         "format_input": "byte",
         "draw_null_as_zero": true,
         "title": "Network Receive vs Transmit Throughput",

dashboards/aws/databases_redshift.json

@@ -137,7 +137,7 @@
       {
         "type": "timeseries",
         "display": "line",
-        "format": "throughput",
+        "format": "size",
         "format_input": "byte",
         "draw_null_as_zero": true,
         "title": "Network Throughput",

dashboards/aws/messaging_msk.json

@@ -63,7 +63,7 @@
       {
         "type": "timeseries",
         "display": "line",
-        "format": "throughput",
+        "format": "size",
         "format_input": "byte",
         "draw_null_as_zero": true,
         "title": "Throughput",

dashboards/aws/storage_efs.json

@@ -37,7 +37,7 @@
       {
         "type": "timeseries",
         "display": "line",
-        "format": "throughput",
+        "format": "size",
         "format_input": "byte",
         "draw_null_as_zero": false,
         "title": "Permitted Throughput",