Duplicate requests during initialization

[blakezimmerman]

During initialization, three duplicate requests are made to the full node. They stem from getSDKWallets which calls the constructors for AptosConnectGoogleWallet, AptosConnectAppleWallet, and AptosConnectGenericWallet. All three of these constructors reach out to the full node to fetch the chain ID. Ideally, the chain ID should be fetched once and passed to these constructors so that dapps don't have duplicate requests slowing down page load.

[0xmaayan]

Root Cause Analysis

During initialization, getSDKWallets() in wallet-adapter-core creates three wallet instances — AptosConnectGoogleWallet, AptosConnectAppleWallet, and AptosConnectGenericWallet. Each of these extends AptosConnectWallet, whose constructor eagerly fetches the chain ID from the full node:

// AptosConnectWallet constructor (in @aptos-connect/wallet-adapter-plugin)
this.chainIdPromise = this.aptosClient.getChainId();

Each instance also creates its own independent Aptos client, so there is no shared caching between them. This results in 3 duplicate HTTP requests to the full node on every page load, all returning the same chain ID.

Why This Is Unnecessary for Most Users

The plugin already has a networkToChainId() helper (used in signMessage) that synchronously maps known networks to their chain IDs:

export function networkToChainId(network: ExtendedNetwork) {
  switch (network) {
    case Network.MAINNET:
      return NetworkToChainId.mainnet;
    case Network.TESTNET:
      return NetworkToChainId.testnet;
    default:
      return undefined;
  }
}

For mainnet and testnet (the vast majority of dapps), the chain ID is already known and doesn't need to be fetched at all.

Proposed Fix

The fix should go into the @aptos-connect/wallet-adapter-plugin package. In the AptosConnectWallet constructor, use networkToChainId() first and only fall back to the HTTP fetch for custom/unknown networks:

const knownChainId = networkToChainId(this.network);
if (knownChainId !== undefined) {
  this.chainId = knownChainId;
  this.chainIdPromise = Promise.resolve(knownChainId);
} else {
  this.chainIdPromise = this.aptosClient.getChainId();
  this.chainIdPromise.then((chainId) => { this.chainId = chainId; });
}

This eliminates all 3 duplicate requests for mainnet/testnet. The same pattern should also be applied to getNetwork(), which currently always awaits the promise even when the chain ID is already known synchronously.