Set SCALE_IMAGE_EXPORT default to true for Windows/Mac, false for Linux

We shouldn't set the default from the current device scale when Archi is launched because it can change if a different monitor is selected on Windows.

You can start the app at 100% display and this preference defaults to false. Then you switch to a 200% display and that preference is still false.

Generally, this should be true for Windows and Mac and false for Linux.

Author: Phillipus

com.archimatetool.editor/src/com/archimatetool/editor/preferences/PreferenceInitializer.java

@@ -10,7 +10,6 @@
 
 import com.archimatetool.editor.ArchiPlugin;
 import com.archimatetool.editor.diagram.figures.connections.IDiagramConnectionFigure;
-import com.archimatetool.editor.ui.ImageFactory;
 import com.archimatetool.editor.utils.PlatformUtils;
 import com.archimatetool.model.IDiagramModelObject;
 import com.archimatetool.model.ILegendOptions;
@@ -136,8 +135,8 @@ public void initializeDefaultPreferences() {
         store.setDefault(USE_LABEL_EXPRESSIONS_IN_ANALYSIS_TABLE, true);
 
         store.setDefault(ADD_DOCUMENTATION_NOTE_ON_RELATION_CHANGE, false);
-        // Windows hi-res and Mac Retina use display scaling, Linux is 100
-        store.setDefault(SCALE_IMAGE_EXPORT, PlatformUtils.isLinux() ? false : ImageFactory.getDeviceZoom() > 100);
+        // Windows and Mac use display scaling, Linux is 100% scaling
+        store.setDefault(SCALE_IMAGE_EXPORT, PlatformUtils.isLinux() ? false : true);
 
         // Animation
         store.setDefault(ANIMATE_VIEW, false);

com.archimatetool.editor/src/com/archimatetool/editor/ui/ImageFactory.java

@@ -57,8 +57,7 @@ public static int getDeviceZoom() {
     /**
      * @return The zoom level for creating images.
      * On Linux scaleImages defaults to false and this should be 100%
-     * On Mac use the device zoom
-     * On Windows use the device zoom
+     * On Mac/Windows use the device zoom
      */
     public static int getImageDeviceZoom() {
         boolean scaleImages = ArchiPlugin.getInstance().getPreferenceStore().getBoolean(IPreferenceConstants.SCALE_IMAGE_EXPORT);

com.archimatetool.help/help/Text/prefs_general.html

@@ -62,7 +62,7 @@ <h3>Other</h3>
 	<br/>
 
 	<p><strong>Export images at native display scale</strong><br/>
-	When this is selected, images are exported and copied to the clipboard at the native display scaling. This is set on by default for Windows operating systems when the display scaling is greater than 100%, and on Mac Retina devices. This is so that the exported image quality is not compromised since it is not possible to set a higher DPI in the image. This setting is usually not needed on Linux displays.</p>
+	When this is selected, images are exported and copied to the clipboard at the native display scaling. This is on by default for Windows and Mac and off for Linux. This ensures that the exported image quality is better at higher display scales. If this option is not selected images are exported at 100% scaling. This setting is usually not needed on Linux displays.</p>
 
 	<p>If the resulting image needs to be at its logical size you could edit it in an image editor and set the DPI to double its value. For example, on Mac change the DPI from to 72 to 144.</p>
 	<br/>