Add another test for expanding nested nots

Author: Happypig375

Sources/AngouriMath/Functions/Simplification/Patterns/Patterns.EqualityInequality.cs

@@ -61,9 +61,9 @@ private static bool OppositeSigns(ComparisonSign left, ComparisonSign right)
             // For complexity to not increase, maximum one AND/OR component can be something other than a comparison operator to propagate NOT into.
             // e.g. not (a > b and b = c) becomes (a <= b or not b = c)
             // Note that Notf(Equalsf) has the same complexity as Equalsf in ComplexityCriteria, so it can be treated as a comparison operator here.
-            Notf(Andf a) when Andf.LinearChildren(a).Count(n => n is not (ComparisonSign or Notf(Equalsf) or Orf)) <= 1 =>
+            Notf(Andf a) when Andf.LinearChildren(a).Count(n => n is not (ComparisonSign or Notf or Orf)) <= 1 =>
                 Andf.LinearChildren(a).Select(e => InequalityEqualityRules(e switch { Notf(var n) => n, var n => new Notf(n) })).Aggregate((a, b) => a | b),
-            Notf(Orf a) when Orf.LinearChildren(a).Count(n => n is not (ComparisonSign or Notf(Equalsf) or Andf)) <= 1 =>
+            Notf(Orf a) when Orf.LinearChildren(a).Count(n => n is not (ComparisonSign or Notf or Andf)) <= 1 =>
                 Orf.LinearChildren(a).Select(e => InequalityEqualityRules(e switch { Notf(var n) => n, var n => new Notf(n) })).Aggregate((a, b) => a & b),
 
             Impliesf(Andf(Greaterf(var any1, var any2), Greaterf(var any2a, var any3)), Greaterf(var any1a, var any3a))

Sources/Tests/UnitTests/PatternsTest/BooleanSimplify.cs

@@ -127,5 +127,26 @@ public void TestProvided(string expr, string? expected)
             var act = expr.ToEntity();
             Assert.Equal(exp, act.Simplify());
         }
+        [Theory]
+        [InlineData("not (not x)", "x")]
+        [InlineData("not (a = b and b = c)", "not a = b or not b = c")]
+        [InlineData("not (a <= b and b < c)", "a > b or b >= c")]
+        [InlineData("not (a > b and b >= c)", "a <= b or b < c")]
+        [InlineData("not (a <= b and b <= c and 1)", "not (1 and a <= b and b <= c)")]
+        [InlineData("not (a = b or b = c)", "not a = b and not b = c")]
+        [InlineData("not (a <= b or b < c)", "a > b and b >= c")]
+        [InlineData("not (a > b or b >= c)", "a <= b and b < c")]
+        [InlineData("not (a <= b or b <= c or 1)", "not (1 or a <= b or b <= c)")]
+        [InlineData("not (a < b or c > d and e = f)", "a >= b and (c <= d or not e = f)")]
+        [InlineData("not (not (a > b and b >= c) and y)", "a > b and b >= c or not y")]
+        [InlineData("not (not (a = b and b = c) and y)", "a = b and b = c or not y")]
+        [InlineData("not (not (not a = b and not b = c) and y)", "not ((a = b or b = c) and y)")]
+        [InlineData("not (a < b and b < c and not c = d and not d and not (e and not (f or g = h)))", "a >= b or b >= c or c = d or d or e and not f and not g = h")]
+        public void NestedNot(string expr, string expected)
+        {
+            var exp = expected.ToEntity();
+            var act = expr.ToEntity();
+            Assert.Equal(exp, act.Simplify());
+        }
     }
 }

Sources/Tests/UnitTests/PatternsTest/SimplifyTest.cs

@@ -161,21 +161,6 @@ [Fact] public void BigSimple1() => AssertSimplifyToString(
         [InlineData("ln(a) - ln(b)", "ln(a / b)")]
         [InlineData("log(2, a) + ln(b)", "log(2, a) + ln(b)")]
         public void PowerRulesTest(string input, string output) => AssertSimplifyToString(input, output);
-        [Theory]
-        [InlineData("not (not x)", "x")]
-        [InlineData("not (a = b and b = c)", "not a = b or not b = c")]
-        [InlineData("not (a <= b and b < c)", "a > b or b >= c")]
-        [InlineData("not (a > b and b >= c)", "a <= b or b < c")]
-        [InlineData("not (a <= b and b <= c and 1)", "not (1 and a <= b and b <= c)")]
-        [InlineData("not (a = b or b = c)", "not a = b and not b = c")]
-        [InlineData("not (a <= b or b < c)", "a > b and b >= c")]
-        [InlineData("not (a > b or b >= c)", "a <= b and b < c")]
-        [InlineData("not (a <= b or b <= c or 1)", "not (1 or a <= b or b <= c)")]
-        [InlineData("not (a < b or c > d and e = f)", "a >= b and (c <= d or not e = f)")]
-        [InlineData("not (not (a > b and b >= c) and y)", "a > b and b >= c or not y")]
-        [InlineData("not (not (a = b and b = c) and y)", "a = b and b = c or not y")]
-        [InlineData("not (not (not a = b and not b = c) and y)", "not ((a = b or b = c) and y)")]
-        public void Boolean(string input, string output) => AssertSimplifyToString(input, output);
     }
 }