fix(swap): stop synth sunset copy on empty asset picker

The output picker used synthDisabled as a generic empty-state, so Native+usdt
(and any other empty filter) showed "Synth minting has been discontinued" to
users redeeming secured assets. Empty lists now always use common.noResult.
Remove the dead synthDisabled prop and unused i18n key.

Author: Naq302

src/renderer/components/modal/tradeDeposit/TradeDepositModal.tsx

@@ -793,7 +793,6 @@ export const TradeDepositModal = (props: TradeDepositModalProps): JSX.Element =>
             hasLedger={false}
             useLedgerHandler={FP.constVoid}
             protocol={currentProtocol}
-            synthDisabled
           />
 
           {/* Wallet Type Selection */}

src/renderer/components/swap/Swap.tsx

@@ -2071,7 +2071,6 @@ export const Swap = ({
             useLedger={useTargetAssetLedger}
             useLedgerHandler={onClickUseTargetAssetLedger}
             hasLedger={hasTargetAssetLedger}
-            synthDisabled
           />
           <div className="absolute -top-[32px] left-[calc(50%-30px)] flex flex-col justify-center">
             <div className="w-60px h-60px">

src/renderer/components/uielements/assets/assetInput/AssetInput.tsx

@@ -53,7 +53,6 @@ export type Props = {
   className?: string
   classNameInput?: string
   onChangePercent?: (percents: number) => void
-  synthDisabled?: boolean
 }
 
 /**
@@ -98,8 +97,7 @@ export const AssetInput = (props: Props): JSX.Element => {
     useLedgerHandler,
     protocol,
     className = '',
-    classNameInput = '',
-    synthDisabled = false
+    classNameInput = ''
   } = props
 
   const inputWrapperRef = useRef<FixmeType>()
@@ -203,7 +201,6 @@ export const AssetInput = (props: Props): JSX.Element => {
             dialogHeadline={intl.formatMessage({ id: 'common.asset.chooseAsset' })}
             shadowless
             disabled={disabled}
-            synthDisabled={synthDisabled}
           />
           {walletBalance ? (
             <div className="flex items-center justify-end space-x-1 pr-4">

src/renderer/components/uielements/assets/assetMenu/AssetMenu.helper.test.ts

@@ -16,6 +16,8 @@ import {
 
 const assetUSDT = assetFromStringEx('ETH.USDT-0xdAC17F958D2ee523a2206206994597C13D831ec7')
 const assetUSDC = assetFromStringEx('ETH.USDC-0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48')
+const assetSecuredUSDT = assetFromStringEx('ETH-USDT-0xdAC17F958D2ee523a2206206994597C13D831ec7')
+const assetSynthUSDT = assetFromStringEx('ETH/USDT-0xdAC17F958D2ee523a2206206994597C13D831ec7')
 const assetAvaxEth = { ...AssetETH, chain: AssetAVAX.chain, type: AssetType.TOKEN }
 const assetBscEth = { ...AssetETH, chain: AssetBSC.chain, type: AssetType.TOKEN }
 
@@ -62,5 +64,26 @@ describe('AssetMenu.helper', () => {
       expect(assetMatchesSearch(assetUSDT, 'usdt')).toBe(true)
       expect(assetMatchesSearch(AssetETH, 'usdt')).toBe(false)
     })
+
+    it('keeps L1 and secured USDT on All + usdt, drops synths', () => {
+      const assets = [assetUSDT, assetSecuredUSDT, assetSynthUSDT, AssetETH]
+      const sorted = filterAndSortAssetsForMenu(assets, 'usdt', ExtendedAssetType.All)
+      expect(sorted).toContainEqual(assetUSDT)
+      expect(sorted).toContainEqual(assetSecuredUSDT)
+      expect(sorted).not.toContainEqual(assetSynthUSDT)
+      expect(sorted.every((a) => a.type !== AssetType.SYNTH)).toBe(true)
+    })
+
+    it('returns no USDT matches on Native + usdt (token, not native)', () => {
+      const assets = [assetUSDT, assetSecuredUSDT, assetSynthUSDT, AssetETH]
+      const sorted = filterAndSortAssetsForMenu(assets, 'usdt', ExtendedAssetType.Native)
+      expect(sorted).toEqual([])
+    })
+
+    it('keeps secured USDT on the Secured filter', () => {
+      const assets = [assetUSDT, assetSecuredUSDT, assetSynthUSDT]
+      const sorted = filterAndSortAssetsForMenu(assets, '', ExtendedAssetType.Secured)
+      expect(sorted).toEqual([assetSecuredUSDT])
+    })
   })
 })

src/renderer/components/uielements/assets/assetMenu/AssetMenu.tsx

@@ -1,7 +1,7 @@
 import React, { useCallback, useState, useMemo, useRef } from 'react'
 
 import { Dialog, DialogBackdrop, DialogPanel } from '@headlessui/react'
-import { ArchiveBoxXMarkIcon, CheckIcon, XMarkIcon, ExclamationTriangleIcon } from '@heroicons/react/24/outline'
+import { ArchiveBoxXMarkIcon, CheckIcon, XMarkIcon } from '@heroicons/react/24/outline'
 import { Network } from '@xchainjs/xchain-client'
 import { AnyAsset, assetToString, AssetType, Chain } from '@xchainjs/xchain-util'
 import clsx from 'clsx'
@@ -26,7 +26,6 @@ export type Props = {
   className?: string
   headline?: string
   network: Network
-  synthDisabled?: boolean
 }
 
 export { ExtendedAssetType, filterButtons } from './AssetMenu.helper'
@@ -40,8 +39,7 @@ export const AssetMenu = (props: Props): JSX.Element => {
     headline = emptyString,
     network,
     onClose,
-    className = '',
-    synthDisabled = false
+    className = ''
   } = props
 
   const [searchValue, setSearchValue] = useState<string>(emptyString)
@@ -72,22 +70,14 @@ export const AssetMenu = (props: Props): JSX.Element => {
         filteredAssets,
         NEA.fromArray,
         O.fold(
-          () =>
-            !synthDisabled ? (
-              <div className="flex h-full w-[calc(100%-32px)] flex-col items-center justify-center rounded-lg border border-solid border-gray0 p-1 px-20px py-50px dark:border-gray0d">
-                <ArchiveBoxXMarkIcon className="h-[75px] w-[75px] text-gray0 dark:text-gray0d" />
-                <h2 className="mb-10px text-[14px] text-gray1 uppercase dark:text-gray1d">
-                  {intl.formatMessage({ id: 'common.noResult' })}
-                </h2>
-              </div>
-            ) : (
-              <div className="flex h-full w-[calc(100%-32px)] flex-col items-center justify-center rounded-lg border border-solid border-gray0 p-1 px-20px py-50px dark:border-gray0d">
-                <ExclamationTriangleIcon className="h-[75px] w-[75px] text-warning0 dark:text-warning0d" />
-                <h2 className="mb-10px text-center text-[14px] text-warning0 uppercase dark:text-warning0d">
-                  {intl.formatMessage({ id: 'swap.synth.warning' })}
-                </h2>
-              </div>
-            ),
+          () => (
+            <div className="flex h-full w-[calc(100%-32px)] flex-col items-center justify-center rounded-lg border border-solid border-gray0 p-1 px-20px py-50px dark:border-gray0d">
+              <ArchiveBoxXMarkIcon className="h-[75px] w-[75px] text-gray0 dark:text-gray0d" />
+              <h2 className="mb-10px text-[14px] text-gray1 uppercase dark:text-gray1d">
+                {intl.formatMessage({ id: 'common.noResult' })}
+              </h2>
+            </div>
+          ),
           (assets) => (
             <div className="w-[calc(100%-32px)] overflow-y-auto rounded-lg border border-solid border-gray0 p-1 dark:border-gray0d">
               {FP.pipe(
@@ -110,7 +100,7 @@ export const AssetMenu = (props: Props): JSX.Element => {
           )
         )
       ),
-    [asset, filteredAssets, handleChangeAsset, intl, network, synthDisabled]
+    [asset, filteredAssets, handleChangeAsset, intl, network]
   )
 
   const searchHandler = useCallback(({ target }: React.ChangeEvent<HTMLInputElement>) => {

src/renderer/components/uielements/assets/assetSelect/AssetSelect.tsx

@@ -20,7 +20,6 @@ type Props = {
   shadowless?: boolean
   disabled?: boolean
   network: Network
-  synthDisabled?: boolean
 }
 
 export const AssetSelect = (props: Props): JSX.Element => {
@@ -33,8 +32,7 @@ export const AssetSelect = (props: Props): JSX.Element => {
     showAssetName = true,
     disabled = false,
     shadowless = false,
-    network,
-    synthDisabled = false
+    network
   } = props
 
   const [openMenu, setOpenMenu] = useState<boolean>(false)
@@ -64,7 +62,6 @@ export const AssetSelect = (props: Props): JSX.Element => {
         onClose={() => setOpenMenu(false)}
         headline={dialogHeadline}
         network={network}
-        synthDisabled={synthDisabled}
       />
       <BaseButton
         className={clsx(

src/renderer/i18n/de/swap.ts

@@ -39,8 +39,6 @@ const swap: SwapMessages = {
     'Dein Swap ist mit diesem Mindestwert basierend auf der ausgewählten {tolerance}% Slippage-Toleranz abgesichert. Falls eine Preisänderung vor der Transaktions-Bestätigung mehr als {tolerance}% zu Deinem Nachteil beträgt, wird Deine Swap-Transaktion zurücküberwiesen.',
   'swap.min.result.protected': 'Gesichertes Swap-Ergebnis',
   'swap.address.evm.warning': 'NICHT zu Smart Contract Adressen tauschen',
-  'swap.synth.warning':
-    'Das Minten von Synths wurde eingestellt. Die Einlösung von Synths ist noch 3 Monate lang möglich — bitte löse sie ein, solange du kannst.',
   'swap.mode.rapid': 'Rapid',
   'swap.mode.streaming': 'Streaming',
   'swap.mode.instant': 'Sofort',

src/renderer/i18n/en/swap.ts

@@ -38,8 +38,6 @@ const swap: SwapMessages = {
     'Your swap is protected by this minimum value based on selected {tolerance}% slippage tolerance. In case the price changes unfavourable more than {tolerance}% your swap transaction will be reverted before confirmation.',
   'swap.min.result.protected': 'Protected swap result',
   'swap.address.evm.warning': 'Do NOT swap to Smart Contract addresses',
-  'swap.synth.warning':
-    'Synth minting has been discontinued. Synth redemption will remain available for the next 3 months — please redeem while you can.',
   'swap.mode.rapid': 'Rapid',
   'swap.mode.streaming': 'Streaming',
   'swap.mode.instant': 'Instant',

src/renderer/i18n/es/swap.ts

@@ -40,8 +40,6 @@ const swap: SwapMessages = {
     'Su swap está protegido por este valor mínimo basado en el {tolerance}% de tolerancia de deslizamiento seleccionado. En caso de que el precio cambie desfavorablemente más del {tolerance}%, su operación de swap se revertirá antes de la confirmación.',
   'swap.min.result.protected': 'Resultado del swap protegido',
   'swap.address.evm.warning': 'NO intercambiar a direcciones de Smart Contract',
-  'swap.synth.warning':
-    'La acuñación de Synths se ha descontinuado. La redención de Synths estará disponible durante los próximos 3 meses — por favor, canjéalos mientras puedas.',
   'swap.mode.rapid': 'Rapid',
   'swap.mode.streaming': 'Streaming',
   'swap.mode.instant': 'Instantáneo',

src/renderer/i18n/fr/swap.ts

@@ -39,8 +39,6 @@ const swap: SwapMessages = {
     "Votre échange est protégé par cette valeur minimale basée sur la tolérance de slippage de {tolerance} % sélectionnée. Dans le cas où le prix change défavorablement de plus de {tolerance} %, votre transaction d'échange sera annulée avant la confirmation.",
   'swap.min.result.protected': 'Résultat du swap protégé',
   'swap.address.evm.warning': 'NE PAS échanger vers des adresses de Smart Contract',
-  'swap.synth.warning':
-    "La création de Synths a été arrêtée. Le rachat des Synths restera disponible pendant encore 3 mois — veuillez les échanger tant que c'est possible.",
   'swap.mode.rapid': 'Rapid',
   'swap.mode.streaming': 'Streaming',
   'swap.mode.instant': 'Instantané',