chore: upgrade tools and tests to node >18

Author: jbedard

.aspect/rules/external_repository_action_cache/npm_translate_lock_LTE4Nzc1MDcwNjU=

@@ -23,14 +23,14 @@ examples/stack_traces/package.json=2011229626
 examples/webpack_cli/package.json=1911342006
 js/private/coverage/bundle/package.json=-1582937149
 js/private/test/image/package.json=1430754959
-js/private/test/js_run_devserver/package.json=-381403605
+js/private/test/js_run_devserver/package.json=-459994543
 js/private/worker/src/package.json=251852959
 npm/private/test/npm_package/package.json=-1991705133
 npm/private/test/npm_package_publish/package.json=-646566766
-npm/private/test/package.json=606610593
+npm/private/test/package.json=322962683
 npm/private/test/vendored/is-odd/package.json=1041695223
 npm/private/test/vendored/lodash-4.17.21.tgz=-1206623349
 npm/private/test/vendored/semver-max/package.json=578664053
-package.json=-724085359
-pnpm-lock.yaml=-463011088
+package.json=1068891966
+pnpm-lock.yaml=1499299525
 pnpm-workspace.yaml=854106668

.github/workflows/release_prep.sh

@@ -36,7 +36,7 @@ bazel_dep(name = "aspect_rules_js", version = "${TAG:1}")
 # Optionally you can pin a different node version:
 bazel_dep(name = "rules_nodejs", version = "6.3.0")
 node = use_extension("@rules_nodejs//nodejs:extensions.bzl", "node", dev_dependency = True)
-node.toolchain(node_version = "16.14.2")
+node.toolchain(node_version = "18.14.2")
 #################################
 
 npm = use_extension("@aspect_rules_js//npm:extensions.bzl", "npm", dev_dependency = True)

MODULE.bazel

@@ -81,25 +81,14 @@ use_repo(node_dev, "node18_linux_arm64")
 use_repo(node_dev, "node18_linux_s390x")
 use_repo(node_dev, "node18_linux_ppc64le")
 use_repo(node_dev, "node18_windows_amd64")
-use_repo(node_dev, "node16_linux_amd64")
-use_repo(node_dev, "node16_darwin_arm64")
-use_repo(node_dev, "node16_darwin_amd64")
-use_repo(node_dev, "node16_linux_arm64")
-use_repo(node_dev, "node16_linux_s390x")
-use_repo(node_dev, "node16_linux_ppc64le")
-use_repo(node_dev, "node16_windows_amd64")
-node_dev.toolchain(node_version = "16.14.2")
-node_dev.toolchain(
-    name = "node16",
-    node_version = "16.13.1",
-)
+node_dev.toolchain(node_version = "18.20.4")
 node_dev.toolchain(
     name = "node18",
-    node_version = "18.13.0",
+    node_version = "18.20.4",
 )
 node_dev.toolchain(
     name = "node20",
-    node_version = "20.11.1",
+    node_version = "20.17.0",
 )
 
 ############################################

e2e/js_image_docker/.nvmrc

@@ -1 +1 @@
-16.14.2
+18.14.2

e2e/js_image_oci/WORKSPACE

@@ -14,7 +14,7 @@ rules_js_dependencies()
 
 load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
 
-rules_js_register_toolchains(node_version = "16.14.2")
+rules_js_register_toolchains(node_version = "18.14.2")
 
 load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")
 

e2e/npm_link_package-esm/WORKSPACE

@@ -9,7 +9,7 @@ rules_js_dependencies()
 
 load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
 
-rules_js_register_toolchains(node_version = "16.14.2")
+rules_js_register_toolchains(node_version = "18.14.2")
 
 load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")
 

e2e/npm_link_package-rerooted/WORKSPACE

@@ -9,7 +9,7 @@ rules_js_dependencies()
 
 load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
 
-rules_js_register_toolchains(node_version = "16.14.2")
+rules_js_register_toolchains(node_version = "18.14.2")
 
 load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")
 

e2e/npm_link_package/WORKSPACE

@@ -9,7 +9,7 @@ rules_js_dependencies()
 
 load("@aspect_rules_js//js:toolchains.bzl", "rules_js_register_toolchains")
 
-rules_js_register_toolchains(node_version = "16.14.2")
+rules_js_register_toolchains(node_version = "18.14.2")
 
 load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")
 

e2e/pnpm_lockfiles/MODULE.bazel

@@ -73,8 +73,8 @@ npm = use_extension(
         "lock-%s__rollup__3.29.4__links" % version,
 
         # Dep only referenced via npm: should have the real package name in the repo name
-        "lock-%s__at_types_sizzle__2.3.9" % version,
-        "lock-%s__at_types_sizzle__2.3.9__links" % version,
+        "lock-%s__at_types_sizzle__2.3.10" % version,
+        "lock-%s__at_types_sizzle__2.3.10__links" % version,
 
         # Deps with circles
         "lock-%s__at_aspect-test_a__5.0.2__links" % version,

e2e/pnpm_lockfiles/base/package.json

@@ -41,10 +41,10 @@
     "devDependencies": {
         "@aspect-test/b": "5.0.2",
         "@aspect-test/c": "^2.0.0",
-        "@types/node": "16.18.11",
+        "@types/node": "18.19.54",
         "@types/archiver": "5.3.1",
-        "alias-only-sizzle": "npm:@types/sizzle@~2.3.9",
-        "alias-types-node": "npm:@types/node@~16.18.11"
+        "alias-only-sizzle": "npm:@types/sizzle@~2.3.10",
+        "alias-types-node": "npm:@types/node@~18.19.54"
     },
     "optionalDependencies": {
         "@aspect-test/c": "2.0.0",