refactor: remove host_yq from label_store (#2398)

### Changes are visible to end-users: no
At worst they will get a single restart but realistically non-ancient
bazels handle restarts gracefully

### Test plan
- Covered by existing test cases

Author: dzbarsky

npm/private/npm_translate_lock_state.bzl

@@ -33,7 +33,7 @@ WARNING: `update_pnpm_lock` attribute in `npm_translate_lock(name = "{rctx_name}
 
     _init_external_repository_action_cache(priv, attr)
 
-    _init_common_labels(priv, rctx, attr, label_store, is_windows)
+    _init_common_labels(priv, attr, label_store)
 
     _init_patches_labels(priv, rctx, attr, label_store)
 
@@ -49,9 +49,10 @@ WARNING: `update_pnpm_lock` attribute in `npm_translate_lock(name = "{rctx_name}
 
     # parse the pnpm lock file incase since we need the importers list for additional init
     # TODO(windows): utils.exists is not yet support on Windows
-    pnpm_lock_exists = is_windows or utils.exists(rctx, label_store.path("pnpm_lock"))
+    pnpm_lock_path = label_store.path("pnpm_lock")
+    pnpm_lock_exists = is_windows or utils.exists(rctx, pnpm_lock_path)
     if pnpm_lock_exists:
-        _load_lockfile(priv, rctx, label_store)
+        _load_lockfile(priv, rctx, attr, pnpm_lock_path, is_windows)
         _init_patched_dependencies_labels(priv, rctx, attr, label_store)
 
     # May depend on lockfile state
@@ -60,7 +61,7 @@ WARNING: `update_pnpm_lock` attribute in `npm_translate_lock(name = "{rctx_name}
     if _should_update_pnpm_lock(priv):
         _init_importer_labels(priv, label_store)
 
-    _init_npmrc(priv, rctx, attr, label_store)
+    _init_npmrc(priv, rctx, attr, label_store, is_windows)
 
     _copy_common_input_files(priv, rctx, attr, label_store, pnpm_lock_exists)
 
@@ -78,7 +79,7 @@ def _validate_attrs(attr, is_windows):
         fail("only one of npm_package_lock or yarn_lock may be set")
 
 ################################################################################
-def _init_common_labels(priv, rctx, attr, label_store, is_windows):
+def _init_common_labels(priv, attr, label_store):
     # data files
     # only initialize if update_pnpm_lock is set since data files are unused otherwise
     if _should_update_pnpm_lock(priv):
@@ -114,9 +115,6 @@ def _init_common_labels(priv, rctx, attr, label_store, is_windows):
     # pnpm-workspace.yaml file
     label_store.add_sibling("lock", "pnpm_workspace", PNPM_WORKSPACE_FILENAME)
 
-    # yq is used for parsing the pnpm lock file
-    label_store.add("host_yq", Label("@{}_{}//:yq{}".format(attr.yq_toolchain_prefix, repo_utils.platform(rctx), ".exe" if is_windows else "")))
-
 ################################################################################
 def _init_pnpm_labels(priv, rctx, attr, label_store):
     # Note that we must reference the node binary under the platform-specific node
@@ -225,20 +223,19 @@ def _init_root_package(priv, rctx, attr, label_store):
         priv["root_package_json"] = {}
 
 ################################################################################
-def _init_npmrc(priv, rctx, attr, label_store):
+def _init_npmrc(priv, rctx, attr, label_store, is_windows):
     if not label_store.has("npmrc"):
         # check for a .npmrc next to the pnpm-lock.yaml file
-        _maybe_npmrc(priv, rctx, attr, label_store, "sibling_npmrc")
+        _maybe_npmrc(priv, rctx, attr, label_store, "sibling_npmrc", is_windows)
 
     if label_store.has("npmrc"):
         _load_npmrc(priv, rctx, label_store.path("npmrc"))
 
     if attr.use_home_npmrc:
-        _load_home_npmrc(priv, rctx)
+        _load_home_npmrc(priv, rctx, is_windows)
 
 ################################################################################
-def _maybe_npmrc(priv, rctx, attr, label_store, key):
-    is_windows = repo_utils.is_windows(rctx)
+def _maybe_npmrc(priv, rctx, attr, label_store, key, is_windows):
     if is_windows:
         # TODO(windows): utils.exists is not yet support on Windows
         return
@@ -460,7 +457,7 @@ def _load_npmrc(priv, rctx, npmrc_path):
     priv["npm_auth"].update(auth)
 
 ################################################################################
-def _load_home_npmrc(priv, rctx):
+def _load_home_npmrc(priv, rctx, is_windows):
     home_directory = repo_utils.get_home_directory(rctx)
     if not home_directory:
         # buildifier: disable=print
@@ -472,21 +469,21 @@ WARNING: Cannot determine home directory in order to load home `.npmrc` file in
     home_npmrc_path = "{}/{}".format(home_directory, NPM_RC_FILENAME)
 
     # TODO(windows): utils.exists is not yet support on Windows
-    is_windows = repo_utils.is_windows(rctx)
     if is_windows or utils.exists(rctx, home_npmrc_path):
         _load_npmrc(priv, rctx, home_npmrc_path)
 
 ################################################################################
-def _load_lockfile(priv, rctx, label_store):
+def _load_lockfile(priv, rctx, attr, pnpm_lock_path, is_windows):
     importers = {}
     packages = {}
     patched_dependencies = {}
     lock_version = None
     lock_parse_err = None
 
+    host_yq = Label("@{}_{}//:yq{}".format(attr.yq_toolchain_prefix, repo_utils.platform(rctx), ".exe" if is_windows else ""))
     yq_args = [
-        str(label_store.path("host_yq")),
-        str(label_store.path("pnpm_lock")),
+        str(rctx.path(host_yq)),
+        str(pnpm_lock_path),
         "-o=json",
     ]
     result = rctx.execute(yq_args)