Skip to content

Commit 2ad0cea

Browse files
authored
fix(venv): Honor user warnings setting (#691)
Fixes #676 ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Fixed an issue which caused `py_venv_*` to emit suppressed warnings ### Test plan - Manual testing
1 parent 685eb0f commit 2ad0cea

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

py/tools/py/src/venv.rs

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -857,20 +857,18 @@ pub fn populate_venv(
857857
}
858858

859859
had_collision = true;
860-
eprintln!("Collision detected at destination: {}", dest.display());
861-
for source in sources {
862-
match source {
863-
Command::Copy { src, .. } | Command::CopyAndPatch { src, .. } => {
864-
if emit_error {
860+
if emit_error {
861+
eprintln!("Collision detected at destination: {}", dest.display());
862+
for source in sources {
863+
match source {
864+
Command::Copy { src, .. } | Command::CopyAndPatch { src, .. } => {
865865
eprintln!(" - Source: {} (Copy)", src.display())
866866
}
867-
}
868-
Command::Symlink { src, .. } => {
869-
if emit_error {
867+
Command::Symlink { src, .. } => {
870868
eprintln!(" - Source: {} (Symlink)", src.display())
871869
}
870+
_ => {}
872871
}
873-
_ => {}
874872
}
875873
}
876874
}

0 commit comments

Comments
 (0)