chore: enable aspect workflows for more Bazel versions (#832)

* chore: enable aspect workflows for more Bazel versions

* fix icon

* add bazel 6

* note: needs bazel-contrib/bazelrc-preset.bzl#64

* chore: upgrade bazelrc-preset

* chore: preset isn't applied

* turn one off

Author: alexeagle

.aspect/workflows/config.yaml

@@ -1,13 +1,15 @@
 # See https://docs.aspect.build/workflows/configuration
 workspaces:
     .:
-        icon: ts
+        icon: typescript
         label: rules_ts
-        tasks:
-            - test:
     e2e/smoke:
         tasks:
-            - test:
+            - bazel-6:
+                  without: true
+            - bazel-7:
+                  queue: aspect-medium
+            - bazel-8:
                   queue: aspect-medium
             - format:
                   without: true
@@ -17,7 +19,11 @@ workspaces:
                   without: true
     e2e/external_dep:
         tasks:
-            - test:
+            - bazel-6:
+                  queue: aspect-medium
+            - bazel-7:
+                  queue: aspect-medium
+            - bazel-8:
                   queue: aspect-medium
             - format:
                   without: true
@@ -27,7 +33,11 @@ workspaces:
                   without: true
     e2e/worker:
         tasks:
-            - test:
+            - bazel-6:
+                  queue: aspect-medium
+            - bazel-7:
+                  queue: aspect-medium
+            - bazel-8:
                   queue: aspect-medium
             - format:
                   without: true
@@ -37,7 +47,11 @@ workspaces:
                   without: true
     e2e/test:
         tasks:
-            - test:
+            - bazel-6:
+                  queue: aspect-medium
+            - bazel-7:
+                  queue: aspect-medium
+            - bazel-8:
                   queue: aspect-medium
             - format:
                   without: true
@@ -47,6 +61,23 @@ workspaces:
                   without: true
 tasks:
     - test:
+          name: 'Test (Bazel 6.x)'
+          id: bazel-6
+          bazel:
+              flags:
+                  - --incompatible_merge_fixed_and_default_shell_env
+          env:
+              USE_BAZEL_VERSION: 6.x
+    - test:
+          name: 'Test (Bazel 7.x)'
+          id: bazel-7
+          env:
+              USE_BAZEL_VERSION: 7.x
+    - test:
+          name: 'Test (Bazel 8.x)'
+          id: bazel-8
+          env:
+              USE_BAZEL_VERSION: 8.x
     - format:
           queue: aspect-medium
           use_args_file: false

MODULE.bazel

@@ -22,7 +22,7 @@ bazel_dep(name = "rules_proto", version = "6.0.0")
 ####### Dev dependencies ########
 
 bazel_dep(name = "aspect_rules_lint", version = "1.2.1", dev_dependency = True)
-bazel_dep(name = "bazelrc-preset.bzl", version = "1.0.1", dev_dependency = True)
+bazel_dep(name = "bazelrc-preset.bzl", version = "1.1.0", dev_dependency = True)
 bazel_dep(name = "buildifier_prebuilt", version = "6.4.0", dev_dependency = True)
 bazel_dep(name = "rules_go", version = "0.46.0", dev_dependency = True, repo_name = "io_bazel_rules_go")
 bazel_dep(name = "rules_nodejs", version = "6.2.0", dev_dependency = True)

tools/preset.bazelrc

@@ -24,6 +24,15 @@ coverage --build_runfile_links
 common:debug --nocache_test_results
 # Docs: https://registry.build/flag/[email protected]?filter=cache_test_results
 
+# Don’t encourage a rules author to update their deps if not needed.
+# These bazel_dep calls should indicate the minimum version constraint of the ruleset.
+# If the author instead updates to the newest of any of their transitives, as this flag would suggest,
+# then they'll also force their dependents to a newer version.
+# Context:
+# https://bazelbuild.slack.com/archives/C014RARENH0/p1691158021917459?thread_ts=1691156601.420349&cid=C014RARENH0
+common:ruleset --check_direct_dependencies="off"
+# Docs: https://registry.build/flag/[email protected]?filter=check_direct_dependencies
+
 # On CI, use colors to highlight output on the screen. Set to `no` if your CI does not display colors.
 common:ci --color="yes"
 # Docs: https://registry.build/flag/[email protected]?filter=color
@@ -148,6 +157,13 @@ common:ci --remote_local_fallback
 common:ci --remote_timeout=3600
 # Docs: https://registry.build/flag/[email protected]?filter=remote_timeout
 
+# Do not upload locally executed action results to the remote cache.
+# This should be the default for local builds so local builds cannot poison the remote cache.
+#
+# Note that this flag is flipped to True under --config=ci, see below.
+common --noremote_upload_local_results
+# Docs: https://registry.build/flag/[email protected]?filter=remote_upload_local_results
+
 # On CI, upload locally executed action results to the remote cache.
 common:ci --remote_upload_local_results
 # Docs: https://registry.build/flag/[email protected]?filter=remote_upload_local_results