fix: use === in the comparisons + remove excess null checks (wip)

Author: aminya

lib/adapters/autocomplete-adapter.ts

@@ -52,12 +52,12 @@ class PossiblyResolvedCompletionItem {
  */
 export default class AutocompleteAdapter {
   public static canAdapt(serverCapabilities: ServerCapabilities): boolean {
-    return serverCapabilities.completionProvider != null
+    return serverCapabilities.completionProvider !== undefined
   }
 
   public static canResolve(serverCapabilities: ServerCapabilities): boolean {
     return (
-      serverCapabilities.completionProvider != null && serverCapabilities.completionProvider.resolveProvider === true
+      serverCapabilities.completionProvider !== undefined && serverCapabilities.completionProvider.resolveProvider === true
     )
   }
 
@@ -83,7 +83,7 @@ export default class AutocompleteAdapter {
     minimumWordLength?: number
   ): Promise<ac.AnySuggestion[]> {
     const triggerChars =
-      server.capabilities.completionProvider != null
+      server.capabilities.completionProvider !== undefined
         ? server.capabilities.completionProvider.triggerCharacters || []
         : []
 
@@ -214,11 +214,11 @@ export default class AutocompleteAdapter {
     const cache = this._suggestionCache.get(server)
     if (cache) {
       const possiblyResolvedCompletionItem = cache.suggestionMap.get(suggestion)
-      if (possiblyResolvedCompletionItem != null && possiblyResolvedCompletionItem.isResolved === false) {
+      if (possiblyResolvedCompletionItem !== undefined && possiblyResolvedCompletionItem.isResolved === false) {
         const resolvedCompletionItem = await server.connection.completionItemResolve(
           possiblyResolvedCompletionItem.completionItem
         )
-        if (resolvedCompletionItem != null) {
+        if (resolvedCompletionItem !== null) {
           AutocompleteAdapter.resolveSuggestion(resolvedCompletionItem, suggestion, request, onDidConvertCompletionItem)
           possiblyResolvedCompletionItem.isResolved = true
         }
@@ -235,7 +235,7 @@ export default class AutocompleteAdapter {
   ): void {
     // only the `documentation` and `detail` properties may change when resolving
     AutocompleteAdapter.applyDetailsToSuggestion(resolvedCompletionItem, suggestion)
-    if (onDidConvertCompletionItem != null) {
+    if (onDidConvertCompletionItem !== undefined) {
       onDidConvertCompletionItem(resolvedCompletionItem, suggestion as ac.AnySuggestion, request)
     }
   }
@@ -394,7 +394,7 @@ export default class AutocompleteAdapter {
       suggestion as TextSuggestion
     )
     AutocompleteAdapter.applySnippetToSuggestion(item, suggestion as SnippetSuggestion)
-    if (onDidConvertCompletionItem != null) {
+    if (onDidConvertCompletionItem !== undefined) {
       onDidConvertCompletionItem(item, suggestion as ac.AnySuggestion, request)
     }
 
@@ -425,7 +425,7 @@ export default class AutocompleteAdapter {
       suggestion.description = item.documentation
     }
 
-    if (item.documentation != null && typeof item.documentation === "object") {
+    if (item.documentation !== undefined && typeof item.documentation === "object") {
       // Newer format specifies the kind of documentation, assign appropriately
       if (item.documentation.kind === "markdown") {
         suggestion.descriptionMarkdown = item.documentation.value
@@ -469,7 +469,7 @@ export default class AutocompleteAdapter {
    */
   public static applySnippetToSuggestion(item: CompletionItem, suggestion: SnippetSuggestion): void {
     if (item.insertTextFormat === InsertTextFormat.Snippet) {
-      suggestion.snippet = item.textEdit != null ? item.textEdit.newText : item.insertText || ""
+      suggestion.snippet = item.textEdit !== undefined ? item.textEdit.newText : item.insertText || ""
     }
   }
 

lib/adapters/code-action-adapter.ts

@@ -43,7 +43,7 @@ export default class CodeActionAdapter {
     range: Range,
     diagnostics: atomIde.Diagnostic[]
   ): Promise<atomIde.CodeAction[]> {
-    if (linterAdapter == null) {
+    if (linterAdapter === undefined) {
       return []
     }
     assert(serverCapabilities.codeActionProvider, "Must have the textDocument/codeAction capability")
@@ -100,9 +100,9 @@ export default class CodeActionAdapter {
           // Until the Linter API provides a place to store the code,
           // there's no real way for the code actions API to give it back to us.
           const converted = Convert.atomIdeDiagnosticToLSDiagnostic(diagnostic)
-          if (diagnostic.range != null && diagnostic.text != null) {
+          if (diagnostic.text !== undefined) {
             const code = linterAdapter.getDiagnosticCode(editor, diagnostic.range, diagnostic.text)
-            if (code != null) {
+            if (code !== null) {
               converted.code = code
             }
           }

lib/adapters/command-execution-adapter.ts

@@ -7,7 +7,7 @@ export default class CommandExecutionAdapter {
   private static commandsCustomCallbacks = new Map<string, CommandCustomCallbackFunction>()
 
   public static canAdapt(serverCapabilities: ServerCapabilities): boolean {
-    return serverCapabilities.executeCommandProvider != null
+    return serverCapabilities.executeCommandProvider !== undefined
   }
 
   public static registerCustomCallbackForCommand(command: string, callback: CommandCustomCallbackFunction): void {

lib/adapters/datatip-adapter.ts

@@ -39,11 +39,11 @@ export default class DatatipAdapter {
     const documentPositionParams = Convert.editorToTextDocumentPositionParams(editor, point)
 
     const hover = await connection.hover(documentPositionParams)
-    if (hover == null || DatatipAdapter.isEmptyHover(hover)) {
+    if (hover === null || DatatipAdapter.isEmptyHover(hover)) {
       return null
     }
 
-    const range = hover.range == null ? Utils.getWordAtPosition(editor, point) : Convert.lsRangeToAtomRange(hover.range)
+    const range = hover.range === undefined ? Utils.getWordAtPosition(editor, point) : Convert.lsRangeToAtomRange(hover.range)
 
     const markedStrings = (Array.isArray(hover.contents) ? hover.contents : [hover.contents]).map((str) =>
       DatatipAdapter.convertMarkedString(editor, str)
@@ -53,6 +53,7 @@ export default class DatatipAdapter {
   }
 
   private static isEmptyHover(hover: Hover): boolean {
+    // TODO hover.contents is never null!
     return (
       hover.contents == null ||
       (typeof hover.contents === "string" && hover.contents.length === 0) ||

lib/adapters/definition-adapter.ts

@@ -46,14 +46,14 @@ export default class DefinitionAdapter {
     const definitionLocations = DefinitionAdapter.normalizeLocations(
       await connection.gotoDefinition(documentPositionParams)
     )
-    if (definitionLocations == null || definitionLocations.length === 0) {
+    if (definitionLocations === null || definitionLocations.length === 0) {
       return null
     }
 
     let queryRange
     if (serverCapabilities.documentHighlightProvider) {
       const highlights = await connection.documentHighlight(documentPositionParams)
-      if (highlights != null && highlights.length > 0) {
+      if (highlights.length > 0) {
         queryRange = highlights.map((h) => Convert.lsRangeToAtomRange(h.range))
       }
     }
@@ -72,10 +72,7 @@ export default class DefinitionAdapter {
    * @returns An {Array} of {Location}s or {null} if the locationResult was null.
    */
   public static normalizeLocations(locationResult: Location | Location[]): Location[] | null {
-    if (locationResult == null) {
-      return null
-    }
-    return (Array.isArray(locationResult) ? locationResult : [locationResult]).filter((d) => d.range.start != null)
+    return (Array.isArray(locationResult) ? locationResult : [locationResult]).filter((d) => d.range.start != null) // TODO d.range.start is never null!
   }
 
   /**

lib/adapters/document-sync-adapter.ts

@@ -105,12 +105,12 @@ export default class DocumentSyncAdapter {
 
   private _handleGrammarChange(editor: TextEditor): void {
     const sync = this._editors.get(editor)
-    if (sync != null && !this._editorSelector(editor)) {
+    if (sync !== undefined && !this._editorSelector(editor)) {
       this._editors.delete(editor)
       this._disposable.remove(sync)
       sync.didClose()
       sync.dispose()
-    } else if (sync == null && this._editorSelector(editor)) {
+    } else if (sync === undefined && this._editorSelector(editor)) {
       this._handleNewEditor(editor)
     }
   }
@@ -162,10 +162,11 @@ export class TextEditorSyncAdapter {
     private _versions: Map<string, number>,
     private _reportBusyWhile: Utils.ReportBusyWhile
   ) {
+    // TODO atom.project.onDidChangeFiles is never null
     this._fakeDidChangeWatchedFiles = atom.project.onDidChangeFiles == null
 
     const changeTracking = this.setupChangeTracking(_documentSync)
-    if (changeTracking != null) {
+    if (changeTracking !== null) {
       this._disposable.add(changeTracking)
     }
 
@@ -293,7 +294,7 @@ export class TextEditorSyncAdapter {
 
   private _bumpVersion(): void {
     const filePath = this._editor.getPath()
-    if (filePath == null) {
+    if (filePath === undefined) {
       return
     }
     this._versions.set(filePath, this._getVersion(filePath) + 1)
@@ -305,7 +306,7 @@ export class TextEditorSyncAdapter {
    */
   private didOpen(): void {
     const filePath = this._editor.getPath()
-    if (filePath == null) {
+    if (filePath === undefined) {
       return
     } // Not yet saved
 
@@ -332,7 +333,7 @@ export class TextEditorSyncAdapter {
    * the connected language server.
    */
   public didClose(): void {
-    if (this._editor.getPath() == null) {
+    if (this._editor.getPath() === undefined) {
       return
     } // Not yet saved
 

lib/adapters/find-references-adapter.ts

@@ -38,10 +38,6 @@ export default class FindReferencesAdapter {
     projectRoot: string | null
   ): Promise<atomIde.FindReferencesReturn | null> {
     const locations = await connection.findReferences(FindReferencesAdapter.createReferenceParams(editor, point))
-    if (locations == null) {
-      return null
-    }
-
     const references: atomIde.Reference[] = locations.map(FindReferencesAdapter.locationToReference)
     return {
       type: "data",

lib/adapters/linter-push-v2-adapter.ts

@@ -120,9 +120,9 @@ export default class LinterPushV2Adapter {
    */
   public getDiagnosticCode(editor: atom.TextEditor, range: atom.Range, text: string): DiagnosticCode | null {
     const path = editor.getPath()
-    if (path != null) {
+    if (path !== undefined) {
       const diagnosticCodes = this._diagnosticCodes.get(path)
-      if (diagnosticCodes != null) {
+      if (diagnosticCodes !== undefined) {
         return diagnosticCodes.get(getCodeKey(range, text)) || null
       }
     }

lib/adapters/notifications-adapter.ts

@@ -46,7 +46,7 @@ export default class NotificationsAdapter {
           text: a.title,
           onDidClick: () => {
             resolve(a)
-            if (notification != null) {
+            if (notification !== null) {
               notification.dismiss()
             }
           },
@@ -55,7 +55,7 @@ export default class NotificationsAdapter {
 
       const notification = addNotificationForMessage(params.type, params.message, options)
 
-      if (notification != null) {
+      if (notification !== null) {
         notification.onDidDismiss(() => {
           resolve(null)
         })

lib/adapters/outline-view-adapter.ts

@@ -93,7 +93,7 @@ export default class OutlineViewAdapter {
     return symbols.map((symbol) => {
       const tree = OutlineViewAdapter.hierarchicalSymbolToOutline(symbol)
 
-      if (symbol.children != null) {
+      if (symbol.children !== undefined) {
         tree.children = OutlineViewAdapter.createHierarchicalOutlineTrees(symbol.children)
       }
 
@@ -129,37 +129,37 @@ export default class OutlineViewAdapter {
     // Create a map of containers by name with all items that have that name
     const containers = allItems.reduce((map, item) => {
       const name = item.outline.representativeName
-      if (name != null) {
+      if (name !== undefined) {
         const container = map.get(name)
-        if (container == null) {
+        if (container === undefined) {
           map.set(name, [item.outline])
         } else {
           container.push(item.outline)
         }
       }
       return map
-    }, new Map())
+    }, new Map<string, atomIde.OutlineTree[]>())
 
     const roots: atomIde.OutlineTree[] = []
 
     // Put each item within its parent and extract out the roots
     for (const item of allItems) {
       const containerName = item.containerName
       const child = item.outline
-      if (containerName == null || containerName === "") {
+      if (containerName === undefined || containerName === "") {
         roots.push(item.outline)
       } else {
         const possibleParents = containers.get(containerName)
         let closestParent = OutlineViewAdapter._getClosestParent(possibleParents, child)
-        if (closestParent == null) {
+        if (closestParent === null) {
           closestParent = {
             plainText: containerName,
             representativeName: containerName,
             startPosition: new Point(0, 0),
             children: [child],
           }
           roots.push(closestParent)
-          if (possibleParents == null) {
+          if (possibleParents === undefined) {
             containers.set(containerName, [closestParent])
           } else {
             possibleParents.push(closestParent)
@@ -174,10 +174,10 @@ export default class OutlineViewAdapter {
   }
 
   private static _getClosestParent(
-    candidates: atomIde.OutlineTree[] | null,
+    candidates: atomIde.OutlineTree[] | undefined,
     child: atomIde.OutlineTree
   ): atomIde.OutlineTree | null {
-    if (candidates == null || candidates.length === 0) {
+    if (candidates === undefined || candidates.length === 0) {
       return null
     }
 
@@ -192,7 +192,7 @@ export default class OutlineViewAdapter {
         if (
           parent === undefined ||
           parent.startPosition.isLessThanOrEqual(candidate.startPosition) ||
-          (parent.endPosition != null &&
+          (parent.endPosition !== undefined &&
             candidate.endPosition &&
             parent.endPosition.isGreaterThanOrEqual(candidate.endPosition))
         ) {
@@ -222,7 +222,7 @@ export default class OutlineViewAdapter {
           value: symbol.name,
         },
       ],
-      icon: icon != null ? icon : undefined,
+      icon: icon !== null ? icon : undefined,
       representativeName: symbol.name,
       startPosition: Convert.positionToPoint(symbol.selectionRange.start),
       endPosition: Convert.positionToPoint(symbol.selectionRange.end),
@@ -246,7 +246,7 @@ export default class OutlineViewAdapter {
           value: symbol.name,
         },
       ],
-      icon: icon != null ? icon : undefined,
+      icon: icon !== null ? icon : undefined,
       representativeName: symbol.name,
       startPosition: Convert.positionToPoint(symbol.location.range.start),
       endPosition: Convert.positionToPoint(symbol.location.range.end),