fix(client): align getCurrentValidators auto-renew fields with helicon-fuji

Author: anishnar

client/src/methods/pChain/types/getCurrentValidators.ts

@@ -31,7 +31,7 @@ export type GetCurrentValidatorsParameters = {
  * @property validators[].validationRewardOwner - Specifies the owner of the potential reward earned from staking. Includes locktime, threshold, and an array of addresses. Omitted if subnetID is not the Primary Network
  * @property validators[].delegationRewardOwner - Specifies the owner of the potential reward earned from delegations. Includes locktime, threshold, and an array of addresses. Omitted if subnetID is not the Primary Network
  * @property validators[].validatorAuthority - Specifies the owner authorized to update auto-renewed validator config. Includes locktime, threshold, and an array of addresses. Only present for auto-renewed validators
- * @property validators[].period - Auto-renewed validator cycle period in seconds. Only present for auto-renewed validators
+ * @property validators[].nextPeriod - Duration of the next auto-renewed validation cycle in seconds. Only present for auto-renewed validators
  * @property validators[].autoCompoundRewardShares - Auto-compound reward shares in parts per million. Only present for auto-renewed validators
  * @property validators[].signer - The node's BLS public key and proof of possession. Omitted if the validator doesn't have a BLS public key. Omitted if subnetID is not the Primary Network
  * @property validators[].delegatorCount - The number of delegators on this validator. Omitted if subnetID is not the Primary Network
@@ -124,10 +124,10 @@ export type GetCurrentValidatorsReturnType = {
     };
 
     /**
-     * Auto-renewed validator cycle period in seconds.
+     * Duration of the next auto-renewed validation cycle in seconds.
      * Only present for auto-renewed validators.
      */
-    period?: string;
+    nextPeriod?: string;
 
     /**
      * Auto-compound reward shares in parts per million.

client/src/methods/wallet/pChain/addAutoRenewedValidatorTxCompat.ts

@@ -91,8 +91,12 @@ const removeSerializedWeight = (
  * `unexpectedLayout()` rather than emitting a silently-corrupted, validly-signed
  * staking tx. We can't read the installed AvalancheJS version at runtime (its
  * `exports` map hides `package.json`), so the exact version pin in `package.json`
- * plus these structural checks are the guard. ACP-236's wire format is not yet
- * frozen (devnet only); revisit this whenever AvalancheJS is bumped.
+ * plus these structural checks are the guard. ACP-236's wire format is frozen
+ * (avalanche-foundation/ACPs#294) and AvalancheJS serializes it natively as of
+ * ava-labs/avalanchejs#1000 (releases >= 5.1.1), which also removes the
+ * `weight` property this shim reads — so the shim would throw there. Delete it
+ * and use the native serialization when the `@avalabs/avalanchejs` pin is
+ * bumped to a release containing that fix.
  */
 export function useAvalancheGoAddAutoRenewedValidatorTxSerialization(
   tx: AddAutoRenewedValidatorTx

e2e/test/acp236-auto-renewed-validator.integration.test.ts

@@ -139,7 +139,7 @@ async function waitForAutoRenewedValidatorConfig(
     lastValidators = validators;
     const validator = validators.find((candidate) => candidate.txID === txID);
     if (
-      validator?.period === expectedPeriod.toString() &&
+      validator?.nextPeriod === expectedPeriod.toString() &&
       validator.autoCompoundRewardShares === expectedAutoCompoundRewardShares.toString()
     ) {
       return validator;