chore(reexecute/c): remove go bench from benchmark #4640
+131
−64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
As part of #4508, this PR removes usage of
go benchfrom the reexecution test. This offers the following benefits:addResult()on the new benchmark tool.How this works
*testing.B./scripts/benchmark_cchain_range.shgo benchHow this was tested
CI + ran
task reexecute-cchain-range START_BLOCK=1 END_BLOCK=100_000 BENCHMARK_OUTPUT_FILE=<INSERT_CUSTOM_PATH_HERE>locally and got the following:[ { "name": "BenchmarkReexecuteRange/[1,100000]-Config-default-Runner-dev", "value": "254.90228109633716", "unit": "mgas/s" } ]To test that benchmark results display correctly on the GAB dashboard, I created a sample benchmark (https://github.com/RodrigoVillar/sample-reexecution-custom-benchmark/blob/main/main.go) which is a copy-and-paste of the benchmarking code in this PR and plotted some points into my own dashboard. The results of the sample benchmark can be seen below:
Attached is a link to the sample benchmark dashboard: https://rodrigovillar.github.io/sample-reexecution-custom-benchmark/dev/bench/
Need to be documented in RELEASES.md?
No
TODOs after merging
gh-pagesbranch of data points which usego bench