Add WaitForAcceptance Flag to XSVM.transfer #4659
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a WaitForAcceptance flag to the XSVM transfer command, allowing callers to return immediately after issuing a transaction without waiting for acceptance. This is useful for load testing scenarios or when confirmation waiting is not required.
Key Changes
- Added
WaitForAcceptanceboolean flag with a default value oftrueto maintain backward compatibility - Modified the transfer logic to conditionally wait for transaction acceptance based on the flag value
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vms/example/xsvm/cmd/issue/transfer/flags.go | Added WaitForAcceptanceKey constant, flag definition, Config field, and parsing logic for the new flag |
| vms/example/xsvm/cmd/issue/transfer/cmd.go | Modified Transfer function to conditionally await transaction acceptance based on the new flag |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
StephenButtolph
approved these changes
Dec 4, 2025
yacovm
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Allows the caller to return from
Transferwithout needing to wait for the transaction to be accepted. Can be helpful for load testing, or just scenarios where you don't care about waiting.How this works
Adds an additional flag to the xsvm.Transfer cmd
How this was tested
Need to be documented in RELEASES.md?