[tmpnet] Remove node restart from Network.CreateSubnets #4664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the CreateSubnets method by removing the optional node restart functionality and making it the caller's responsibility to restart nodes after subnet creation. This change acknowledges that the post-bootstrap subnet creation code path has degraded and is no longer actively used, so maintaining the automatic restart capability is unnecessary.
Key changes:
- Removed the
restartRequiredboolean parameter fromCreateSubnets - Eliminated the conditional node restart logic within
CreateSubnets - Updated function documentation to explicitly state that node restart is the caller's responsibility
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maru-ava
force-pushed
the
maru/tmpnet-create-subnets-only-on-bootstrap
branch
2 times, most recently
from
dd1b701 to
95ebd93
Compare
maru-ava
changed the title
maru-ava
changed the title
maru-ava
force-pushed
the
maru/tmpnet-create-subnets-only-on-bootstrap
branch
3 times, most recently
from
6e6dc72 to
d3cd9b7
Compare
maru-ava
force-pushed
the
maru/tmpnet-create-subnets-only-on-bootstrap
branch
from
d3cd9b7 to
da4c680
Compare
maru-ava
force-pushed
the
maru/tmpnet-create-subnets-only-on-bootstrap
branch
from
0b16d9a to
f531365
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
tmpnet used to have working support for creating subnets after network bootstrap. Subsequently, that code path has degraded due to subnet creation only being performed as part of bootstrap to both speed up suite setup and avoid disruptive node restart during test execution.
Rather than maintain the unused ability to create subnets post-bootstrap, Network.CreateSubnets is updated to return the set of nodes affected by subnet creation (so they can be restarted if they are already running) rather than taking any responsibility for node restart.
How this was tested
CI
Need to be documented in RELEASES.md?
N/A