Geometry.dispose() bugfix. #53
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally added by Rob, but after discussing with him it was concluded that because the Loader3D could essentially load anything, the handle property does not really have a place anymore.
Loader3D would previously add containers that had been loaded even though they already were parented (assumingly to something else in the file.) This commit fixes this bug using a more general-purpose approach to adding scene assets to the Loader3D as they come in.
Because the token always has a listener, the check for hasEventListener() was always true and errors were never thrown. Copied this check out into Loader3D so that errors are thrown when a load error occurrs and there is no LOAD_ERROR listener on the Loader3D instance.
Because asset loader would only check whether a parsing had COMPLETED to decide whether to resume or not, it would sometimes try to resume failed parsings. To avoid this, it now checks for parsingPaused instead of !parsingComplete.
Using short for numJoints in a skeleton block, instead of 32-bit int which was previuosly the case.
MichaelPlank
pushed a commit
to Pro3Games/away3d-core-broomstick
that referenced
this pull request
Sep 20, 2011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was trying to remove SubGeometry twice from Vector (a shift and a splice (in removeSubGeometry)). This has been fixed now. (shift removed).