feat(gen2-migration): add deployment status validation for lock command #14326
+366
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iankhou
reviewed
Nov 10, 2025
There was a problem hiding this comment.
There are no dependency changes for your code, so we should not modify the lockfile in this PR.
Author
There was a problem hiding this comment.
The lock.ts file has an import added to the code, wouldn't that warrant changes in the yarn.lock file? The Build and Test CI check is failing without it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds deployment status validation to the gen2-migration lock command to prevent locking when the CloudFormation stack is not in
UPDATE_COMPLETEorCREATE_COMPLETE.Added UX improvement with printer.success() to display validation success status.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.