Skip to content

Commit 9b0f0e8

Browse files
authored
feat: Add NetworkType + IPDiscovery to ReplicationGroup (#179)
Issue [#2565](aws-controllers-k8s/community#2565) Description of changes: * support NetworkType + IPDiscovery * add unit tests By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent c7eefb8 commit 9b0f0e8

18 files changed

+765
-654
lines changed
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
ack_generate_info:
2-
build_date: "2025-07-23T02:15:05Z"
3-
build_hash: b2dc0f44e0b08f041de14c3944a5cc005ba97c8f
2+
build_date: "2025-08-08T21:25:54Z"
3+
build_hash: b4fbf4e427daaef74ed873aac01e4a9ca68fb479
44
go_version: go1.24.5
5-
version: v0.50.0
6-
api_directory_checksum: cd3855ca5e9598e4a45cdc8b295054981b08dbb7
5+
version: v0.50.0-3-gb4fbf4e
6+
api_directory_checksum: 5a16cea62c98405d3786f1ee1aad22ff3fafc7d6
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.32.6
99
generator_config_info:
10-
file_checksum: d70e645a0a1ac78d523b7ff0b09ccbfd9bbbfb96
10+
file_checksum: a3aa9d437d76c0a739168005043783103bf199da
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation

apis/v1alpha1/generator.yaml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,8 @@ resources:
178178
PrimaryClusterId: # note: "PrimaryClusterID" will not function properly
179179
compare:
180180
is_ignored: true
181-
181+
NetworkType:
182+
is_immutable: true
182183
hooks:
183184
sdk_read_many_post_set_output:
184185
template_path: hooks/replication_group/sdk_read_many_post_set_output.go.tpl
@@ -426,11 +427,5 @@ ignore:
426427
- CreateReplicationGroupInput.ClusterMode
427428
- ModifyReplicationGroupOutput.ReplicationGroup.ClusterMode
428429
- ModifyReplicationGroupOutput.ReplicationGroup.PendingModifiedValues.ClusterMode
429-
- CreateReplicationGroupInput.IpDiscovery
430-
- CreateReplicationGroupOutput.ReplicationGroup.IpDiscovery
431430
- Subnet.SupportedNetworkTypes
432431
- CreateReplicationGroupInput.ServerlessCacheSnapshotName
433-
- CreateReplicationGroupOutput.ReplicationGroup.NetworkType
434-
- CreateReplicationGroupInput.NetworkType
435-
# - ModifyReplicationGroupOutput.ReplicationGroup.ipDiscovery
436-
# - ModifyReplicationGroupInput.ipDiscovery

apis/v1alpha1/replication_group.go

Lines changed: 11 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/v1alpha1/types.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/v1alpha1/zz_generated.deepcopy.go

Lines changed: 20 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/elasticache.services.k8s.aws_replicationgroups.yaml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,13 @@ spec:
250250
existing cluster or replication group and create it anew with the earlier
251251
engine version.
252252
type: string
253+
ipDiscovery:
254+
description: |-
255+
The network type you choose when creating a replication group, either ipv4
256+
| ipv6. IPv6 is supported for workloads using Valkey 7.2 and above, Redis
257+
OSS engine version 6.2 and above or Memcached engine version 1.6.6 and above
258+
on all instances built on the Nitro system (http://aws.amazon.com/ec2/nitro/).
259+
type: string
253260
kmsKeyID:
254261
description: The ID of the KMS key used to encrypt the disk in the
255262
cluster.
@@ -294,6 +301,16 @@ spec:
294301
A flag indicating if you have Multi-AZ enabled to enhance fault tolerance.
295302
For more information, see Minimizing Downtime: Multi-AZ (http://docs.aws.amazon.com/AmazonElastiCache/latest/dg/AutoFailover.html).
296303
type: boolean
304+
networkType:
305+
description: |-
306+
Must be either ipv4 | ipv6 | dual_stack. IPv6 is supported for workloads
307+
using Valkey 7.2 and above, Redis OSS engine version 6.2 and above or Memcached
308+
engine version 1.6.6 and above on all instances built on the Nitro system
309+
(http://aws.amazon.com/ec2/nitro/).
310+
type: string
311+
x-kubernetes-validations:
312+
- message: Value is immutable once set
313+
rule: self == oldSelf
297314
nodeGroupConfiguration:
298315
description: |-
299316
A list of node group (shard) configuration options. Each node group (shard)

0 commit comments

Comments
 (0)