Skip to content

Commit 509dc82

Browse files
committed
lateInitialize PerformanceInsightsRetentionPeriod/KMSKeyID
1 parent 459bb1b commit 509dc82

File tree

6 files changed

+58
-17
lines changed

6 files changed

+58
-17
lines changed

apis/v1alpha1/ack-generate-metadata.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ api_directory_checksum: 52968d74358773de28be65be320d1bfb9c91e0bf
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.32.6
99
generator_config_info:
10-
file_checksum: a84060264f0186147ecf4328bdc4e0f484b91268
10+
file_checksum: a972abb0acf6792d031bb58c216c95ba303603c6
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation

apis/v1alpha1/generator.yaml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -349,6 +349,7 @@ resources:
349349
- method: Update
350350
ignore: true
351351
CACertificateIdentifier:
352+
late_initialize: {}
352353
set:
353354
- method: Update
354355
ignore: true
@@ -360,7 +361,8 @@ resources:
360361
set:
361362
- method: Update
362363
ignore: true
363-
Iops:
364+
IOPS:
365+
late_initialize: {}
364366
set:
365367
- method: Update
366368
ignore: true
@@ -377,14 +379,16 @@ resources:
377379
- method: Update
378380
ignore: true
379381
StorageThroughput:
382+
late_initialize: {}
380383
set:
381384
- method: Update
382385
ignore: true
383386
StorageType:
384387
set:
385388
- method: Update
386389
ignore: true
387-
KmsKeyId:
390+
KMSKeyID:
391+
late_initialize: {}
388392
references:
389393
resource: Key
390394
service_name: kms
@@ -447,6 +451,10 @@ resources:
447451
from:
448452
operation: CreateDBInstanceReadReplica
449453
path: PreSignedUrl
454+
PerformanceInsightsKMSKeyID:
455+
late_initialize: {}
456+
PerformanceInsightsRetentionPeriod:
457+
late_initialize: {}
450458
Tags:
451459
compare:
452460
# We have a custom comparison function...

generator.yaml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -349,6 +349,7 @@ resources:
349349
- method: Update
350350
ignore: true
351351
CACertificateIdentifier:
352+
late_initialize: {}
352353
set:
353354
- method: Update
354355
ignore: true
@@ -360,7 +361,8 @@ resources:
360361
set:
361362
- method: Update
362363
ignore: true
363-
Iops:
364+
IOPS:
365+
late_initialize: {}
364366
set:
365367
- method: Update
366368
ignore: true
@@ -377,14 +379,16 @@ resources:
377379
- method: Update
378380
ignore: true
379381
StorageThroughput:
382+
late_initialize: {}
380383
set:
381384
- method: Update
382385
ignore: true
383386
StorageType:
384387
set:
385388
- method: Update
386389
ignore: true
387-
KmsKeyId:
390+
KMSKeyID:
391+
late_initialize: {}
388392
references:
389393
resource: Key
390394
service_name: kms
@@ -447,6 +451,10 @@ resources:
447451
from:
448452
operation: CreateDBInstanceReadReplica
449453
path: PreSignedUrl
454+
PerformanceInsightsKMSKeyID:
455+
late_initialize: {}
456+
PerformanceInsightsRetentionPeriod:
457+
late_initialize: {}
450458
Tags:
451459
compare:
452460
# We have a custom comparison function...

pkg/resource/db_instance/delta.go

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/resource/db_instance/hooks.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -174,16 +174,6 @@ func instanceDeleting(r *resource) bool {
174174
return dbis == StatusDeleting
175175
}
176176

177-
func customPreCompare(delta *ackcompare.Delta, a *resource, b *resource) {
178-
if a.ko.Spec.PerformanceInsightsKMSKeyID == nil {
179-
a.ko.Spec.PerformanceInsightsKMSKeyID = b.ko.Spec.PerformanceInsightsKMSKeyID
180-
}
181-
182-
if a.ko.Spec.PerformanceInsightsRetentionPeriod == nil {
183-
a.ko.Spec.PerformanceInsightsRetentionPeriod = b.ko.Spec.PerformanceInsightsRetentionPeriod
184-
}
185-
}
186-
187177
// function to create restoreDbInstanceFromDbSnapshot payload and call restoreDbInstanceFromDbSnapshot API
188178
func (rm *resourceManager) restoreDbInstanceFromDbSnapshot(
189179
ctx context.Context,

pkg/resource/db_instance/manager.go

Lines changed: 37 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)