fix: add namespace cache fallback to IAMRoleSelector cache (#216)

When the IAMRoleSelector feature is enabled, the IAMRoleSelector cache
runs its own `NamespaceCache` to support namespace based matching.
However, the reconciler's namespace lookup methods (`getDefaultRegion`,
`getEndpointURL`, `getDeletionPolicy`) were only checking
`carmCache.Namespaces`, causing these values to be unavailable when only
the IAMRoleSelector cache was running. This change makes the `Namespaces`
field public on the IAMRoleSelector cache and adds fallback logic in the
reconciler to check `irsCache.Namespaces` when `carmCache.Namespaces`
doesn't have the requested data, ensuring namespace annotations remain
accessible regardless of which cache is active.

Author: a-hilaly

pkg/runtime/iamroleselector/cache.go

@@ -34,7 +34,7 @@ import (
 // Cache wraps the informer for IAMRoleSelector resources
 type Cache struct {
 	sync.RWMutex
-	namespaces *ackcache.NamespaceCache
+	Namespaces *ackcache.NamespaceCache
 	log        logr.Logger
 	informer   cache.SharedIndexInformer
 	selectors  map[string]*ackv1alpha1.IAMRoleSelector // name -> selector
@@ -45,7 +45,7 @@ func NewCache(log logr.Logger) *Cache {
 	return &Cache{
 		log:        log.WithName("cache.iam-role-selector"),
 		selectors:  make(map[string]*ackv1alpha1.IAMRoleSelector),
-		namespaces: ackcache.NewNamespaceCache(log, nil, nil),
+		Namespaces: ackcache.NewNamespaceCache(log, nil, nil),
 	}
 }
 
@@ -79,7 +79,7 @@ func (c *Cache) Run(client dynamic.Interface, namespaceClient kubernetes.Interfa
 
 	factory.Start(stopCh)
 
-	c.namespaces.Run(namespaceClient, stopCh)
+	c.Namespaces.Run(namespaceClient, stopCh)
 }
 
 func (c *Cache) handleAdd(obj interface{}) {
@@ -211,7 +211,7 @@ func (c *Cache) Matches(resource runtime.Object) ([]*ackv1alpha1.IAMRoleSelector
 	}
 
 	namespaceName := metaObj.GetNamespace()
-	namespaceLabels := c.namespaces.GetLabels(namespaceName)
+	namespaceLabels := c.Namespaces.GetLabels(namespaceName)
 	// Get GVK - should be set on ACK resources
 	gvk := resource.GetObjectKind().GroupVersionKind()
 	if gvk.Empty() {

pkg/runtime/reconciler.go

@@ -390,6 +390,9 @@ func (r *resourceReconciler) regionDrifted(desired acktypes.AWSResource) bool {
 	// look for default region in namespace metadata annotations
 	ns := desired.MetaObject().GetNamespace()
 	nsRegion, ok := r.carmCache.Namespaces.GetDefaultRegion(ns)
+	if !ok {
+		nsRegion, ok = r.irsCache.Namespaces.GetDefaultRegion(ns)
+	}
 	if ok {
 		return ackv1alpha1.AWSRegion(nsRegion) != *currentRegion
 	}
@@ -1472,6 +1475,9 @@ func (r *resourceReconciler) getRegion(
 	// look for default region in namespace metadata annotations
 	ns := res.MetaObject().GetNamespace()
 	defaultRegion, ok := r.carmCache.Namespaces.GetDefaultRegion(ns)
+	if !ok {
+		defaultRegion, ok = r.irsCache.Namespaces.GetDefaultRegion(ns)
+	}
 	if ok {
 		return ackv1alpha1.AWSRegion(defaultRegion)
 	}
@@ -1501,6 +1507,9 @@ func (r *resourceReconciler) getDeletionPolicy(
 	// look for default deletion policy in namespace metadata annotations
 	ns := res.MetaObject().GetNamespace()
 	deletionPolicy, ok = r.carmCache.Namespaces.GetDeletionPolicy(ns, r.sc.GetMetadata().ServiceAlias)
+	if !ok {
+		deletionPolicy, ok = r.irsCache.Namespaces.GetDeletionPolicy(ns, r.sc.GetMetadata().ServiceAlias)
+	}
 	if ok {
 		return ackv1alpha1.DeletionPolicy(deletionPolicy)
 	}
@@ -1520,6 +1529,9 @@ func (r *resourceReconciler) getEndpointURL(
 	// look for endpoint url in the namespace annotations
 	namespace := res.MetaObject().GetNamespace()
 	endpointURL, ok := r.carmCache.Namespaces.GetEndpointURL(namespace)
+	if !ok {
+		endpointURL, ok = r.irsCache.Namespaces.GetEndpointURL(namespace)
+	}
 	if ok {
 		return endpointURL
 	}