Skip to content

Commit 92a17b7

Browse files
authored
Merge pull request #46 from leenmin-aws/bugfix/oidc-client-regex
Add hyphen support to OIDC client ID regex
2 parents a9a1579 + 56130d6 commit 92a17b7

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

bin/convert-cfn-template.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ function parameterizeTemplate(template, lambdas) {
214214
},
215215
OIDCClientId: {
216216
Type: 'String',
217-
AllowedPattern: '^[a-zA-Z0-9]{1,255}$',
217+
AllowedPattern: '^[a-zA-Z0-9_-]{1,255}$',
218218
Description: 'OIDC Client ID'
219219
},
220220
OIDCIssuerURL: {

bin/environment.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ app_id=$(prompt_for_value "AmazonQAppId" "Amazon Q Application ID (copy from AWS
5858
region=$(prompt_for_value "AmazonQRegion" "Amazon Q Region" $(aws configure get region) "^[a-z]{2}-[a-z]+-[0-9]+$")
5959
ttl_days=$(prompt_for_value "ContextDaysToLive" "Number of days to keep conversation context" "90" "^[1-9][0-9]{0,3}$")
6060
oidc_idp_name=$(prompt_for_value "OIDCIdPName" "Name of Identity Provider (Okta, Cognito, Other)" "Okta" "^[a-zA-Z]{1,255}$")
61-
oidc_client_id=$(prompt_for_value "OIDCClientId" "OIDC Client ID" "none" "^[a-zA-Z0-9]{1,255}$")
61+
oidc_client_id=$(prompt_for_value "OIDCClientId" "OIDC Client ID" "none" "^[a-zA-Z0-9_-]{1,255}$")
6262
oidc_issuer_url=$(prompt_for_value "OIDCIssuerURL" "OIDC Issuer URL" "none" "^https://[a-zA-Z0-9.-]+(:[0-9]+)?(/.*)?$")
6363
gateway_idc_app_arn=$(prompt_for_value "GatewayIdCAppARN" "Q Gateway IdC App Arn" "none" "^arn:aws[a-zA-Z-]*:[a-zA-Z0-9-]*:[a-z0-9-]*:[0-9]{12}:[a-zA-Z0-9:/._-]+$")
6464

0 commit comments

Comments
 (0)