-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Support auth scheme preference config #3268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mullermp
wants to merge
5
commits into
version-3
Choose a base branch
from
auth-scheme-pref
base: version-3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detected 2 possible performance regressions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall approach looks good to me! Left a question.
jterapin
approved these changes
Jul 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢✨
gems/aws-sdk-core/lib/aws-sdk-core/plugins/credentials_configuration.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/plugins/credentials_configuration.rb
Outdated
Show resolved
Hide resolved
…ration.rb Co-authored-by: Juli Tera <[email protected]>
…ration.rb Co-authored-by: Juli Tera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support auth scheme preference config using
ENV['AWS_AUTH_SCHEME_PREFERENCE']
orauth_scheme_preference
shared config. Configuration values are an array in code and a comma separated string in env/shared config and do not use name spaces. Invalid values are ignored. If an auth scheme is resolved and preferred, the credentials/token is expected. This differs from original design because v3 does not resolve auth per operation but rather on client initialize.