chore: Add Swiftlint analyzer to lint CI job (#1999)

Author: jbelkins

.github/workflows/lint.yml

@@ -18,11 +18,26 @@ jobs:
 
   swiftlint:
     if: github.repository == 'awslabs/aws-sdk-swift' || github.event_name == 'pull_request'
-    runs-on: ubuntu-latest
-    container:
-      image: ghcr.io/realm/swiftlint:0.58.2
+    runs-on: macos-15
     steps:
       - name: Checkout sources
         uses: actions/checkout@v2
-      - name: Run swiftlint on AWSClientRuntime
+      - name: Install Swiftlint
+        run: |
+          HOMEBREW_NO_AUTO_UPDATE=1 brew install swiftlint
+          which swiftlint
+          swiftlint --version
+      - name: Run swiftlint
         run: swiftlint --strict --reporter github-actions-logging
+      - name: Eliminate AWS service clients
+        run: |
+          rm -rf Sources/Services/*
+          cd AWSSDKSwiftCLI
+          swift run AWSSDKSwiftCLI generate-package-manifest ..
+          cd ..
+          echo
+          cat Package.swift
+      - name: Compile project with Xcode
+        run: xcodebuild -scheme aws-sdk-swift-Package -destination platform=macOS > xcodebuild.log
+      - name: Run swiftlint analyzer
+        run: swiftlint analyze --strict --reporter github-actions-logging --compiler-log-path xcodebuild.log

Sources/Core/AWSClientRuntime/Sources/AWSClientRuntime/Customizations/AuthTokenGenerator.swift

@@ -7,7 +7,6 @@
 
 import struct AwsCommonRuntimeKit.CommonRuntimeKit
 import class AWSSDKHTTPAuth.AWSSigV4Signer
-import ClientRuntime
 import Smithy
 import SmithyHTTPAPI
 import SmithyHTTPAuth

Sources/Core/AWSClientRuntime/Sources/AWSClientRuntime/Errors/AWSS3ServiceError.swift

@@ -3,8 +3,6 @@
  * SPDX-License-Identifier: Apache-2.0.
  */
 
-import ClientRuntime
-
 public protocol AWSS3ServiceError: AWSServiceError {
     var requestID2: String? { get }
 }

Sources/Core/AWSClientRuntime/Sources/AWSClientRuntime/HTTP/HttpResponse+AWS.swift

@@ -4,7 +4,6 @@
  */
 
 import class SmithyHTTPAPI.HTTPResponse
-import ClientRuntime
 
 public extension HTTPResponse {
 

Sources/Core/AWSClientRuntime/Sources/AWSClientRuntime/Middlewares/AmzSdkInvocationIdMiddleware.swift

@@ -6,7 +6,6 @@
 //
 
 import ClientRuntime
-import Smithy
 import SmithyHTTPAPI
 import struct Foundation.UUID
 

Sources/Core/AWSClientRuntime/Sources/AWSClientRuntime/Middlewares/Sha256TreeHashMiddleware.swift

@@ -2,7 +2,6 @@
 // SPDX-License-Identifier: Apache-2.0.
 
 import class Smithy.Context
-import AwsCCal
 import ClientRuntime
 import SmithyHTTPAPI
 import struct Foundation.Data

Sources/Core/AWSClientRuntime/Sources/AWSClientRuntime/Middlewares/UserAgentMiddleware.swift

@@ -12,7 +12,6 @@ import SmithyHTTPAPI
 public struct UserAgentMiddleware<OperationStackInput, OperationStackOutput> {
     public let id: String = "UserAgentHeader"
 
-    private let X_AMZ_USER_AGENT: String = "x-amz-user-agent"
     private let USER_AGENT: String = "User-Agent"
 
     let serviceID: String

Sources/Core/AWSClientRuntime/Sources/AWSClientRuntime/Regions/DefaultRegionResolver.swift

@@ -7,7 +7,6 @@
 
 import struct Smithy.SwiftLogger
 @_spi(FileBasedConfig) import AWSSDKCommon
-import ClientRuntime
 
 @_spi(DefaultRegionResolver)
 public struct DefaultRegionResolver: RegionResolver {

Sources/Core/AWSClientRuntime/Sources/AWSClientRuntime/Retry/AWSRetryMode.swift

@@ -5,8 +5,6 @@
 // SPDX-License-Identifier: Apache-2.0
 //
 
-import Foundation
-
 /// The mode of operation for the SDK's retry mechanism.
 ///
 /// This may be specified using the `AWS_RETRY_MODE` environment var, or the `retry_mode` field of the AWS config file.

Sources/Core/AWSClientRuntime/Sources/AWSClientRuntime/UserAgent/AdditionalMetadata.swift

@@ -5,8 +5,6 @@
 // SPDX-License-Identifier: Apache-2.0
 //
 
-import Foundation
-
 struct AdditionalMetadata {
     let name: String
     let value: String?