Skip to content

Commit e5de03f

Browse files
committed
remove unused tree-seq* binding, update review checklist
1 parent 3e53917 commit e5de03f

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

review.md

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -88,17 +88,18 @@ deftype/defrecord no longer creates a `(def Foo ...)` var. Type names are stored
8888

8989
## Review Status
9090

91-
- [x] 1. `sci/lang.cljc`reviewed: removed Named, added HasName
92-
- [ ] 2. `sci/impl/utils.cljc`
93-
- [ ] 3. `sci/impl/deftype.cljc`
94-
- [ ] 4. `sci/impl/records.cljc`
95-
- [ ] 5. `sci/impl/namespaces.cljc`
96-
- [x] 6. `sci/impl/evaluator.cljc`reviewed: removed getName special case, tag-class fallback
97-
- [ ] 7. `sci/impl/analyzer.cljc`
98-
- [ ] 8. `sci/impl/resolve.cljc`
99-
- [ ] 9. `sci/impl/parser.cljc`
100-
- [ ] 10. `sci/impl/multimethods.cljc`
101-
- [ ] 11. `sci/impl/protocols.cljc`
102-
- [x] 12. `sci/impl/hierarchies.cljc`reviewed: ->tag uses string parsing
91+
- [x] 1. `sci/lang.cljc` — removed Named, added HasName
92+
- [x] 2. `sci/impl/utils.cljc` — fixed stale docstring (:refers:types)
93+
- [x] 3. `sci/impl/deftype.cljc` — renamed var → type-meta
94+
- [x] 4. `sci/impl/records.cljc` — renamed var → type-meta
95+
- [x] 5. `sci/impl/namespaces.cljc` — clean
96+
- [x] 6. `sci/impl/evaluator.cljc` — removed getName special case, tag-class fallback
97+
- [x] 7. `sci/impl/analyzer.cljc` — clean
98+
- [x] 8. `sci/impl/resolve.cljc` — clean
99+
- [x] 9. `sci/impl/parser.cljc` — clean
100+
- [x] 10. `sci/impl/multimethods.cljc` — clean
101+
- [x] 11. `sci/impl/protocols.cljc` — clean
102+
- [x] 12. `sci/impl/hierarchies.cljc` — ->tag uses string parsing
103103
- [ ] 13. Tests (defrecords_and_deftype_test)
104104
- [ ] 14. Tests (core_test)
105+
- [x] 15. `sci/pprint.cljc` — renamed .-var → .-type-meta

test/sci/defrecords_and_deftype_test.cljc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -390,8 +390,7 @@
390390
{})))))
391391

392392
(deftest deftype-macroexpand-1-produces-deftype*-test
393-
(let [tree-seq* (fn [form]
394-
(tree-seq seq? seq form))]
393+
(do
395394
(testing "macroexpand-1 of deftype contains deftype* and constructor defn"
396395
(is (true?
397396
(tu/eval*

0 commit comments

Comments
 (0)