Merge pull request #87 from badasswp/refactor/remove-replicated-instances-of-text

Refactor: Use `replaceInput` in place of repeated instances of `text`

Author: badasswp

CHANGELOG.md

@@ -5,6 +5,7 @@
 * Feat: Add Plugin options page.
 * Feat: Add Shortcut command (CMD + F).
 * Feat: Add custom hooks: `afterSearchReplace`, `excludedPostTypes`, `regexPattern`.
+* Refactor: Use `replaceInput` in place of repeated instances of `text`.
 * Test: Add e2e tests for plugin codebase.
 * Tested up to WP 6.9.
 

readme.txt

@@ -68,6 +68,7 @@ Want to add your personal touch? All of our documentation can be found [here](ht
 * Feat: Add Plugin options page.
 * Feat: Add Shortcut command (CMD + F).
 * Feat: Add custom hooks: `afterSearchReplace`, `excludedPostTypes`, `regexPattern`.
+* Refactor: Use `replaceInput` in place of repeated instances of `text`.
 * Test: Add e2e tests for plugin codebase.
 * Tested up to WP 6.9.
 

src/core/app.tsx

@@ -207,7 +207,7 @@ const SearchReplaceForBlockEditor = (): JSX.Element => {
 		select( 'core/block-editor' )
 			.getBlocks()
 			.forEach( ( element: any ) => {
-				recursivelyReplace( element, pattern, replaceInput, status );
+				recursivelyReplace( element, pattern, status );
 			} );
 
 		if ( status && isSavePostEnabled ) {
@@ -271,21 +271,19 @@ const SearchReplaceForBlockEditor = (): JSX.Element => {
 	 *
 	 * @param {any}     element Gutenberg editor block.
 	 * @param {RegExp}  pattern Search pattern.
-	 * @param {string}  text    Replace pattern.
 	 * @param {boolean} status  True (Replace), False (Search).
 	 *
 	 * @return {void}
 	 */
 	const recursivelyReplace = (
 		element: any,
 		pattern: RegExp,
-		text: string,
 		status: boolean
 	): void => {
 		const { name, innerBlocks } = element;
 
 		if ( getAllowedBlocks().indexOf( name ) !== -1 ) {
-			const args = { element, pattern, text, status };
+			const args = { element, pattern, status };
 
 			/**
 			 * Replace Block Attribute.
@@ -310,7 +308,7 @@ const SearchReplaceForBlockEditor = (): JSX.Element => {
 
 		if ( innerBlocks.length ) {
 			innerBlocks.forEach( ( innerElement: any ) => {
-				recursivelyReplace( innerElement, pattern, text, status );
+				recursivelyReplace( innerElement, pattern, status );
 			} );
 		}
 	};
@@ -331,7 +329,6 @@ const SearchReplaceForBlockEditor = (): JSX.Element => {
 		const property = {};
 		const {
 			pattern,
-			text,
 			element: { attributes, clientId, name },
 			status,
 		} = args;
@@ -353,7 +350,7 @@ const SearchReplaceForBlockEditor = (): JSX.Element => {
 		 */
 		const handleAttributeReplacement = (): string => {
 			setReplacements( ( items: number ) => items + 1 );
-			return text;
+			return replaceInput;
 		};
 
 		/**