Merge pull request #4 from bakame-php/feature/resolve-consistency

Adding softError parameter to Url::resolve method

Author: nyamsprod

src/WhatWg/Url.php

@@ -280,11 +280,13 @@ public function toUnicodeString(): string
         }
 
         /**
+         * @param array<int, UrlValidationError> $softErrors
+         *
          * @throws InvalidUrlException
          */
-        public function resolve(string $uri): self
+        public function resolve(string $uri, array &$softErrors = []): self
         {
-            return new self($uri, $this->url->href);
+            return new self($uri, $this->url->href, $softErrors);
         }
 
         /**

tests/WhatWg/UrlTest.php

@@ -233,4 +233,17 @@ public function it_return_the_same_instance_if_nothing_is_changed(): void
         self::assertTrue($urlBis->equals($url));
         self::assertSame($urlBis, $url);
     }
+
+    #[Test]
+    public function it_will_return_soft_errors_when_uri_is_resolved_with_errors(): void
+    {
+        $softErrors = [];
+        $url = new Url("ftp://example.com");
+        $urlBis = $url->resolve("//user:p%61ss@example.org/💩", $softErrors);
+
+        self::assertSame('ftp://user:p%61ss@example.org/%F0%9F%92%A9', $urlBis->toUnicodeString());
+        self::assertNotEmpty($softErrors);
+        self::assertInstanceOf(UrlValidationError::class, $softErrors[0]);
+        self::assertSame(UrlValidationErrorType::InvalidCredentials, $softErrors[0]->type);
+    }
 }