Type definition cannot be resolved under moduleResolution: "NodeNext"

[Jack-Works]

package.json

{
    "type": "module",
    "dependencies": {
        "typescript": "4.9",
        "urlcat": "^3.1.0"
    }
}

tsconfig.json

{
    "compilerOptions": {
        "module": "NodeNext",
        "moduleResolution": "nodenext",
        "strict": true
    },
    "include": ["./src"]
}

src/index.ts

import urlcat from 'urlcat'
//                 ~~~~~~~~
urlcat()

Reports the following error:

Could not find a declaration file for module 'urlcat'. 'node_modules/urlcat/dist/index.mjs' implicitly has an 'any' type.
  Try `npm i --save-dev @types/urlcat` if it exists or add a new declaration (.d.ts) file containing `declare module 'urlcat';`ts(7016)

Suggested changes to fix this problem

diff --git a/package.json b/package.json
--- a/package.json
+++ b/package.json
@@ -11,8 +11,14 @@
   "types": "dist/index.d.ts",
   "exports": {
     ".": {
-      "import": "./dist/index.mjs",
-      "require": "./dist/index.js"
+      "import": {
+        "types": "./dist/index.d.mts",
+        "default": "./dist/index.mjs"
+      },
+      "require": {
+        "types": "./dist/index.d.ts",
+        "default": "./dist/index.js"
+      }
     },
     "./package.json": "./package.json"
   },

and copy ./dist/index.d.ts to ./dist/index.d.mts

[balazsbotond]

Thank you for taking the time to open this issue and suggest fixes to the problem. I kindly ask that you consider creating a pull request with your suggested changes, so that we can review and discuss them further.

Thank you again for your contribution!

[Jack-Works]

Thank you for taking the time to open this issue and suggest fixes to the problem. I kindly ask that you consider creating a pull request with your suggested changes, so that we can review and discuss them further.

Hi, my suggestion needs to copy the output file, which requires changing the build step, I don't know if that is good.

[omarkhatibgg]

if you use patch-package you could make it works by adding to package.json

-      "require": "./dist/index.js"
+      "require": "./dist/index.js",
+      "types": "./dist/index.d.ts"

[devnomic]

Same issue with moduleResolution bundler typescript 5+. There is no type definition.

Could not find a declaration file for module 'urlcat'. '/hello/node_modules/urlcat/dist/index.mjs' implicitly has an 'any' type.

[trevorsmith]

I've created a PR to fix this issue: #264

[benfoster]

Any plans to merge the above?

[ethansimmons]

I'm running to this issue, is there a workaround, or a library that works better with typescript.

[alii]

@ethansimmons while I owe a lot of thanks to urlcat over the years, I've started working on my own version to replace it called pathcat https://www.npmjs.com/package/pathcat

I've also left a note of recognition to urlcat in the readme of pathcat 🙂

[andreyvital]

Create a file urlcat.d.ts and drop its own defs:

declare module "urlcat" {
  import type { IStringifyOptions } from "qs";
  type ParamMap = Record<string, any>;
  type UrlCatConfiguration = Partial<
    Pick<IStringifyOptions, "arrayFormat"> & {
      objectFormat: Partial<Pick<IStringifyOptions, "format">>;
    }
  >;

  declare function urlcat(baseTemplate: string, params: ParamMap): string;
  declare function urlcat(baseUrl: string, path: string): string;

  declare function urlcat(baseUrl: string, pathTemplate: string, params: ParamMap): string;

  declare function urlcat(
    baseUrlOrTemplate: string,
    pathTemplateOrParams: string | ParamMap,
    maybeParams: ParamMap,
    config: UrlCatConfiguration
  ): string;

  declare function configure(
    rootConfig: UrlCatConfiguration
  ): (
    baseUrlOrTemplate: string,
    pathTemplateOrParams: string | ParamMap,
    maybeParams?: ParamMap,
    config?: UrlCatConfiguration
  ) => string;

  declare function query(params: ParamMap, config?: UrlCatConfiguration): string;

  declare function subst(template: string, params: ParamMap): string;

  declare function join(part1: string, separator: string, part2: string): string;

  export { ParamMap, UrlCatConfiguration, configure, urlcat as default, join, query, subst };
}

Not ideal, but it's alright until it gets updated.

[aharapu]

ran into this issue to...