ObjectId Validation Check Fails To Convert To String

[caleberi]

Context

While running queries in our staging environment, all database operations started failing due to a missing id attribute in the model definition. After debugging, we traced the issue to [lib/private/machines/private/process-native-record.js](https://github.com/balderdashy/sails-mongo/blob/master/lib/private/machines/private/process-native-record.js), which processes all incoming MongoDB ObjectId values.

The failure occurred during the validation stage, where the check for ObjectId instances returned false unexpectedly.

Debug Logs

Example of the logs we captured during the failure:

pkValue: new ObjectId("68a891f8c760e876123594df")
Primary key value: 68a891f8c760e876123594df
Primary key is Object: true
Primary key is instance of ObjectId: false

Sample Code

The relevant section of process-native-record.js:

Root Cause

The pkValue instanceof ObjectId check is returning false even when the value is clearly an ObjectId. This prevents the adapter from converting the value into a string, ultimately causing the query to fail with a missing id attribute error.

Observed Error

Sails emitted the following warning when attempting to transform the results:

Warning: Records sent back from a database adapter should always have a valid property
that corresponds with the primary key attribute (`id`). But in this result set,
after transforming columnNames back to attribute names for model `business`,
there is a record with a missing or invalid `id`.

Record:
{
  id: new ObjectId('68a719aa320c7d7207c8cda8'),
  createdAt: '2025-08-21T13:05:46.205Z',
}

Next Steps

Further debugging shows this is likely due to different ObjectId references being used in validation (e.g., multiple mongodb driver instances loaded).

I’ve attached a sample PR to help clarify and resolve the issue:
🔗 [PR #502](balderdashy/sails-mongo#502)

[sailsbot]

@caleberi Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

• look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
• tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
• make sure you've provided clear instructions on how to reproduce the bug from a clean install.
• double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
• read the code of conduct.
• if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.