Skip to content

When using the SetCommandAnnotation in dx11, data can't be stored; provide a possible fix and a patch #3874

Description

@alenwesker

Description of Bug

When using the SetCommandAnnotation in dx11, data can't be stored properly.

The only way to use it is to pass nullptr, nullptr as the first 2 params, other try failed. but with that method, all dc result in the same data.

Steps to reproduce

DX11 game, multithreaded, use SetCommandAnnotation, dx11. pass context and dc, not result in the rdc
pass nullptr, nullptr, do have result, but all dc share the same value.

Environment

  • RenderDoc version: 1.45, captured with 1.7 api, all the newest
  • Operating System: windows 11
  • Graphics API: dx11

I have used my ai agent to fix it, provided as a patch (in the attachment). After applying the patch, with context and dc passed to SetCommandAnnotation, dx11 api do captured successfully with correct annotation data.

Since I am not familiar with the code, I only provide a patch for review instead of a PR.

0001-fixed-annotation-cant-be-stored.patch

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugA crash, misbehaviour, or other problemNeed More InfoMore information is needed from a user to work on this issue

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions