Skip to content

Commit f5f2d25

Browse files
committed
No longer processing multiple pressings of the same record as updates
1 parent b56de95 commit f5f2d25

File tree

2 files changed

+7
-13
lines changed

2 files changed

+7
-13
lines changed

backend/records/Fetcher.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -402,10 +402,12 @@ export default class Fetcher {
402402
};
403403
let existingRecord = await this.mongoClient.findRecord(QUERY);
404404
if (existingRecord) {
405-
let changesDetected = recordUtil.changesDetected(record, existingRecord);
406-
if (changesDetected) {
407-
context.updatedCount++;
405+
if (record._id != existingRecord._id) {
406+
log.debug("Different pressing of record already processed, skipping title=" + record.title);
407+
context.knownCount++;
408+
} else if (recordUtil.changesDetected(record, existingRecord)) {
408409
log.info("Changes detected for record, title=" + record.title + ", id=" + record._id);
410+
context.updatedCount++;
409411

410412
// Merge and save the updated record to MongoDB
411413
let updatedRecord = recordUtil.merge(record, existingRecord);

backend/records/util.js

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -36,16 +36,8 @@ let merge = function(fromRecord, intoRecord) {
3636
* it, for protection of our own internal models.
3737
*/
3838
let changesDetected = function(newRecord, existingRecord) {
39-
let changesDetected = false;
40-
try {
41-
if (newRecord.inWishlist != existingRecord.inWishlist
42-
|| newRecord.rating != existingRecord.rating) {
43-
changesDetected = true;
44-
}
45-
} catch(error) {
46-
changesDetected = true;
47-
}
48-
return changesDetected
39+
return newRecord.inWishlist != existingRecord.inWishlist
40+
|| newRecord.rating != existingRecord.rating;
4941
};
5042

5143
export default {

0 commit comments

Comments
 (0)