chore(core): Lints and Formatting (#129)

* chore(workspace): manifest updates

* chore(core): lints

Author: refcell

crates/core/Cargo.toml

@@ -1,11 +1,15 @@
 [package]
 name = "tips-core"
+description = "Core primitives and utilities for TIPS"
 version.workspace = true
+edition.workspace = true
 rust-version.workspace = true
 license.workspace = true
 homepage.workspace = true
 repository.workspace = true
-edition.workspace = true
+
+[lints]
+workspace = true
 
 [features]
 test-utils = ["dep:alloy-signer-local", "dep:op-alloy-rpc-types"]

crates/core/README.md

@@ -0,0 +1,3 @@
+# `tips-core`
+
+Core primitives and utilities for TIPS.

crates/core/src/lib.rs

@@ -1,3 +1,11 @@
+#![doc = include_str!("../README.md")]
+#![doc(issue_tracker_base_url = "https://github.com/base/tips/issues/")]
+#![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
+#![cfg_attr(not(test), warn(unused_crate_dependencies))]
+#![allow(missing_docs)]
+
+use alloy_rpc_types as _;
+
 pub mod kafka;
 pub mod logger;
 pub mod metrics;

crates/core/src/logger.rs

@@ -14,12 +14,12 @@ impl FromStr for LogFormat {
 
     fn from_str(s: &str) -> Result<Self, Self::Err> {
         match s.to_lowercase().as_str() {
-            "json" => Ok(LogFormat::Json),
-            "compact" => Ok(LogFormat::Compact),
-            "pretty" => Ok(LogFormat::Pretty),
+            "json" => Ok(Self::Json),
+            "compact" => Ok(Self::Compact),
+            "pretty" => Ok(Self::Pretty),
             _ => {
                 warn!("Invalid log format '{}', defaulting to 'pretty'", s);
-                Ok(LogFormat::Pretty)
+                Ok(Self::Pretty)
             }
         }
     }

crates/core/src/test_utils.rs

@@ -18,7 +18,7 @@ pub const TXN_HASH: TxHash =
 pub fn create_bundle_from_txn_data() -> AcceptedBundle {
     AcceptedBundle::new(
         Bundle {
-            txs: vec![TXN_DATA.clone()],
+            txs: vec![TXN_DATA],
             ..Default::default()
         }
         .try_into()
@@ -40,7 +40,7 @@ pub fn create_transaction(from: PrivateKeySigner, nonce: u64, to: Address) -> Op
         .unwrap();
 
     let sig = from.sign_transaction_sync(&mut txn).unwrap();
-    OpTxEnvelope::Eip1559(txn.eip1559().cloned().unwrap().into_signed(sig).clone())
+    OpTxEnvelope::Eip1559(txn.eip1559().cloned().unwrap().into_signed(sig))
 }
 
 pub fn create_test_bundle(

crates/core/src/types.rs

@@ -92,7 +92,7 @@ impl TryFrom<Bundle> for ParsedBundle {
             .transpose()
             .map_err(|e| format!("Invalid UUID: {e:?}"))?;
 
-        Ok(ParsedBundle {
+        Ok(Self {
             txs,
             block_number: bundle.block_number,
             flashblock_number_min: bundle.flashblock_number_min,
@@ -243,7 +243,7 @@ impl BundleTxs for AcceptedBundle {
 
 impl AcceptedBundle {
     pub fn new(bundle: ParsedBundle, meter_bundle_response: MeterBundleResponse) -> Self {
-        AcceptedBundle {
+        Self {
             uuid: bundle.replacement_uuid.unwrap_or_else(Uuid::new_v4),
             txs: bundle.txs,
             block_number: bundle.block_number,
@@ -258,7 +258,7 @@ impl AcceptedBundle {
         }
     }
 
-    pub fn uuid(&self) -> &Uuid {
+    pub const fn uuid(&self) -> &Uuid {
         &self.uuid
     }
 }

crates/ingress-rpc/Cargo.toml

@@ -21,6 +21,7 @@ alloy-signer-local.workspace = true
 reth-optimism-evm.workspace = true
 reth-rpc-eth-types.workspace = true
 account-abstraction-core.workspace = true
+alloy-primitives = { workspace = true, features = ["map-foldhash", "serde"] }
 tokio = { workspace = true, features = ["full"] }
 tracing = { workspace = true, features = ["std"] }
 anyhow = { workspace = true, features = ["std"] }
@@ -33,7 +34,6 @@ backon = { workspace = true, features = ["std", "tokio-sleep"] }
 axum = { workspace = true, features = ["tokio", "http1", "json"] }
 clap = { version = "4.5.47", features = ["std", "derive", "env"] }
 op-alloy-consensus = { workspace = true, features = ["std", "k256", "serde"] }
-alloy-primitives = { workspace = true, features = ["map-foldhash", "serde"] }
 
 [dev-dependencies]
 mockall = "0.13"