Add Eigen 5.0.0 #6006
Add Eigen 5.0.0 #6006
Conversation
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (eigen) have been updated in this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for Eigen version 5.0.0 to the Bazel Central Registry. The changes are well-structured and mostly adhere to the BCR contribution guidelines. I have one piece of feedback regarding an outdated dependency on rules_cc, which should be updated to a more recent version to enhance maintainability and prevent potential dependency conflicts for downstream users.
|
@bazel-io skip_check unstable_url |
bazel-io
added
the
skip-url-stability-check
|
Please rebase the branch |
|
waiting for https://gitlab.com/libeigen/eigen/-/issues/2919#note_2784921071 to see if we can get a stable source url (mirror) from upstream |
|
hmm presubmit complains The package_files one is supposed to be stable as it's manually uploaded instead of autogenerated, see https://gitlab.com/libeigen/eigen/-/issues/2919#note_2786932938 All archives are definitely the same file: $ for f in \
"https://gitlab.com/libeigen/eigen/-/package_files/233618368/download" \
"https://github.com/eigen-mirror/eigen/archive/refs/tags/5.0.0.tar.gz" \
"https://gitlab.com/libeigen/eigen/-/archive/5.0.0/eigen-5.0.0.tar.gz" \
; do echo $f; curl -fsSL $f | sha256sum; done
https://gitlab.com/libeigen/eigen/-/package_files/233618368/download
315c881e19e17542a7d428c5aa37d113c89b9500d350c433797b730cd449c056 -
https://github.com/eigen-mirror/eigen/archive/refs/tags/5.0.0.tar.gz
315c881e19e17542a7d428c5aa37d113c89b9500d350c433797b730cd449c056 -
https://gitlab.com/libeigen/eigen/-/archive/5.0.0/eigen-5.0.0.tar.gz
315c881e19e17542a7d428c5aa37d113c89b9500d350c433797b730cd449c056 -Looks like explicitly adding --> Fixing in #6093, let's land that first |
Use archive_type from source.json if specified Needed in #6006 (comment) --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Looks green now :) @jwnimmer-tri should I add you as maintainer? |
Use archive_type from source.json if specified Needed in bazelbuild#6006 (comment) --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Turns out Eigen 5 is (about to be) released! https://gitlab.com/libeigen/eigen/-/releases/5.0.0 This is an alternative to bazelbuild#6004
5 participants
Turns out Eigen 5 is (about to be) released!
https://gitlab.com/libeigen/eigen/-/releases/5.0.0
This is an alternative to #6004