Skip to content

Conversation

@filmil
Copy link
Contributor

@filmil filmil commented Oct 1, 2025

@bazel-io
Copy link
Member

bazel-io commented Oct 1, 2025

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (elfutils) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@filmil filmil marked this pull request as ready for review October 1, 2025 07:05
@kotlaja
Copy link
Collaborator

kotlaja commented Oct 1, 2025

Let's maybe use the same name of this module as it is already on github: bazel_elfutils?

@filmil
Copy link
Contributor Author

filmil commented Oct 1, 2025 via email

@kotlaja
Copy link
Collaborator

kotlaja commented Oct 2, 2025

Regarding naming convention, the most important rules is to have a succinct and unambiguous name. Here I don't have a strong opinion (that's why I phrased it with question mark and maybe) since also elfutils follows this rule. And it makes sense what you're saying regarding bazel_ prefix, so let's go with how it already is. :)

FWIW, I mostly suggested that name due to the cases where users would search in the BCR for the same name as it is in github.

@kotlaja kotlaja added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Oct 2, 2025
@filmil filmil closed this Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants