Skip to content

Conversation

@UebelAndre
Copy link
Contributor

No description provided.

@bazel-io
Copy link
Member

bazel-io commented Oct 1, 2025

Hello @mortenmj, @lalten, modules you maintain (rules_perl) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces [email protected] and makes a minor modification to an older version. The review has identified two critical issues that violate the Bazel Central Registry's policies. Firstly, an existing module version (0.2.3.bcr.1) has been modified, which goes against the add-only principle of the BCR. Secondly, the new version 0.4.3 is based on the source code of 0.4.2 without a new upstream release, which is misleading. Such a change should be versioned as 0.4.2.bcr.1 for clarity, as per the style guide.

@UebelAndre UebelAndre force-pushed the perl branch 2 times, most recently from 7041cb9 to 95c0d6f Compare October 1, 2025 21:32
@UebelAndre
Copy link
Contributor Author

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Oct 1, 2025
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@bazel-io bazel-io merged commit 4830583 into bazelbuild:main Oct 2, 2025
18 checks passed
@bazel-io bazel-io added the auto-merged This PR is automatically merged by the BCR reviewer bot. label Oct 2, 2025
@UebelAndre UebelAndre deleted the perl branch October 2, 2025 14:09
kotlaja pushed a commit to kotlaja/bazel-central-registry that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merged This PR is automatically merged by the BCR reviewer bot. skip-url-stability-check Skip the URL stability check for the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants