-
Notifications
You must be signed in to change notification settings - Fork 579
[email protected] #6071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[email protected] #6071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces [email protected] and makes a minor modification to an older version. The review has identified two critical issues that violate the Bazel Central Registry's policies. Firstly, an existing module version (0.2.3.bcr.1) has been modified, which goes against the add-only principle of the BCR. Secondly, the new version 0.4.3 is based on the source code of 0.4.2 without a new upstream release, which is misleading. Such a change should be versioned as 0.4.2.bcr.1 for clarity, as per the style guide.
7041cb9 to
95c0d6f
Compare
|
@bazel-io skip_check unstable_url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.
No description provided.