Always send hostname and username in workspace status BES message #27120
Conversation
|
@bazel-io fork 8.5.0 |
github-actions
bot
added
the
awaiting-review
|
@bazel-io fork 7.7.0 |
|
I'd rather this not get merged. Reason being, as it is, there is no guarantee that the username and especially the hostname is consistent with what the workspace status action says. In addition, there is the concern that this may leak these strings against the will of the user; I think it's not a very strong argument because Bazel makes zero explicit effort to hide these from the BES, though. Maybe add an explicit field to the BES somewhere with this data? That would have the advantage of having the data available if |
Per a review comment (bazelbuild#27120 (comment)) on bazelbuild#27120, we here propose to send the hostname and username via the BuildStarted BES message rather than the workspace status BES message.
@lberki Since the BuildStarted event already contains things like the working directory and the workspace directory, would you be agreeable to adding the hostname and username as additional fields in this event? I put up #27421 which does this. |
|
Yep, that's a more reasonable approach, thanks for pre-emptively implementing it. |
github-actions
bot
removed
the
awaiting-review
Per a review comment (#27120 (comment)) on #27120, we here propose to send the hostname and username via the BuildStarted BES message rather than the workspace status BES message. Closes #27421. PiperOrigin-RevId: 825070359 Change-Id: I6e8f2e13e90aa6276f629c1da630a5da8e2468e9
Per a review comment (bazelbuild#27120 (comment)) on bazelbuild#27120, we here propose to send the hostname and username via the BuildStarted BES message rather than the workspace status BES message. Closes bazelbuild#27421. PiperOrigin-RevId: 825070359 Change-Id: I6e8f2e13e90aa6276f629c1da630a5da8e2468e9
4 participants
This information is generally useful for all builds, not just those that run the workspace status action.