Skip to content

Commit cafe67c

Browse files
committed
chore: typecheck dep on all @types
This is simpler for Gazelle to be able to generate, since TS by default includes all @types in compilation. Source code doesn't have to include any indication these 'ambient' types are required.
1 parent cf28458 commit cafe67c

File tree

3 files changed

+5
-10
lines changed

3 files changed

+5
-10
lines changed

frontend/next.js/pages/BUILD.bazel

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,7 @@ ts_project(
2020
visibility = ["//next.js:__subpackages__"],
2121
deps = [
2222
"//next.js:node_modules/@bazel-example/one",
23-
"//next.js:node_modules/@types/is-even",
24-
"//next.js:node_modules/@types/react",
25-
"//next.js:node_modules/@types/react-dom",
23+
"//next.js:node_modules/@types",
2624
"//next.js:node_modules/next",
2725
"//next.js/pages/api",
2826
],
@@ -38,7 +36,7 @@ ts_project(
3836
deps = [
3937
"//next.js:node_modules/@testing-library/jest-dom",
4038
"//next.js:node_modules/@testing-library/react",
41-
"//next.js:node_modules/@types/jest",
39+
"//next.js:node_modules/@types",
4240
"//next.js/pages",
4341
],
4442
)

frontend/packages/one/BUILD.bazel

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,7 @@ ts_project(
1414
declaration = True,
1515
transpiler = "tsc",
1616
# transpile time direct dependencies
17-
deps = [
18-
":node_modules/@types/is-odd",
19-
"//next.js:node_modules/@types/node",
20-
],
17+
deps = [":node_modules/@types"],
2118
)
2219

2320
# make this library available via node_modules

frontend/react/src/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ ts_project(
2323
tsconfig = "//react:tsconfig",
2424
visibility = ["//react:__subpackages__"],
2525
deps = [
26-
"//react:node_modules/@types/react",
26+
"//react:node_modules/@types",
2727
"//react:node_modules/react",
2828
"//react:node_modules/react-dom",
2929
"//react:node_modules/vite-plugin-svgr",
@@ -43,7 +43,7 @@ ts_project(
4343
"//:node_modules/vitest",
4444
"//react:node_modules/@testing-library/jest-dom",
4545
"//react:node_modules/@testing-library/react",
46-
"//react:node_modules/@types/jest",
46+
"//react:node_modules/@types",
4747
],
4848
)
4949

0 commit comments

Comments
 (0)