`remap_paths` in `pkg_tar` is not applied to `deps`

[mering]

Reproduction example:

# BUILD.bazel

load("@rules_pkg//:pkg.bzl", "pkg_tar")

pkg_tar(
    name = "pkg",
    srcs = ["//foo:file.txt"],  # results in bar/file.txt
    remap_paths = {
        "foo": "bar",
    },
    strip_prefix = "/",
    deps = ["//foo"],  # results in foo/file.txt
)


# foo/BUILD.bazel

load("@rules_pkg//:pkg.bzl", "pkg_tar")

exports_files(["file.txt"])

pkg_tar(
    name = "foo",
    srcs = [":file.txt"],
    strip_prefix = "/",
    visibility = ["//visibility:public"],
)

$ bazel build //:pkg.tar && tar tvf bazel-bin/pkg.tar
drwxr-xr-x 0/0               0 2000-01-01 00:00 bar/
-r-xr-xr-x 0/0               0 2000-01-01 00:00 bar/file.txt
drwxr-xr-x 0/0               0 2000-01-01 00:00 foo/
-r-xr-xr-x 0/0               0 2000-01-01 00:00 foo/file.txt

[ashi009]

I'm running into a similar issue, where mode and owner won't apply to the dep tar built by other rules.

Looking at

rules_pkg/pkg/private/tar/tar_writer.py

Lines 283 to 356 in 8c7c2cf

	def add_tar(self,
	tar,
	rootuid=None,
	rootgid=None,
	numeric=False,
	name_filter=None,
	prefix=None):
	"""Merge a tar content into the current tar, stripping timestamp.
	Args:
	tar: the name of tar to extract and put content into the current tar.
	rootuid: user id that we will pretend is root (replaced by uid 0).
	rootgid: group id that we will pretend is root (replaced by gid 0).
	numeric: set to true to strip out name of owners (and just use the
	numeric values).
	name_filter: filter out file by names. If not none, this method will be
	called for each file to add, given the name and should return true if
	the file is to be added to the final tar and false otherwise.
	prefix: prefix to add to all file paths.
	Raises:
	TarFileWriter.Error: if an error happens when uncompressing the tar file.
	"""
	if prefix:
	prefix = prefix.strip('/') + '/'
	if _DEBUG_VERBOSITY > 1:
	print('========================== prefix is', prefix)
	intar = tarfile.open(name=tar, mode='r:*')
	for tarinfo in intar:
	if name_filter is None or name_filter(tarinfo.name):
	if not self.preserve_mtime:
	tarinfo.mtime = self.default_mtime
	if rootuid is not None and tarinfo.uid == rootuid:
	tarinfo.uid = 0
	tarinfo.uname = 'root'
	if rootgid is not None and tarinfo.gid == rootgid:
	tarinfo.gid = 0
	tarinfo.gname = 'root'
	if numeric:
	tarinfo.uname = ''
	tarinfo.gname = ''
	in_name = tarinfo.name
	if prefix:
	in_name = os.path.normpath(prefix + in_name).replace(os.path.sep, '/')
	tarinfo.name = in_name
	self.conditionally_add_parents(
	path=tarinfo.name,
	mtime=tarinfo.mtime,
	mode=0o755,
	uid=tarinfo.uid,
	gid=tarinfo.gid,
	uname=tarinfo.uname,
	gname=tarinfo.gname)
	if prefix is not None:
	# Relocate internal hardlinks as well to avoid breaking them.
	link = tarinfo.linkname
	if link.startswith('.') and tarinfo.type == tarfile.LNKTYPE:
	tarinfo.linkname = '.' + prefix + link.lstrip('.')
	# Remove path pax header to ensure that the proposed name is going
	# to be used. Without this, files with long names will not be
	# properly written to its new path.
	if 'path' in tarinfo.pax_headers:
	del tarinfo.pax_headers['path']
	if tarinfo.isfile():
	# use extractfile(tarinfo) instead of tarinfo.name to preserve
	# seek position in intar
	self._addfile(tarinfo, intar.extractfile(tarinfo))
	else:
	self._addfile(tarinfo)
	intar.close()

add_tar doesn't take hints of remap and other settings like add_file does. And it's definitely not "stripping timestamp" here.