Document upload modals have incorrect 'Associated Parcel' field behaviour

[ancharb]

Describe the Bug
ALCS Document upload modals have the 'Associated Parcel' field when they shouldn't, and missing it when they should. This might stem from the variance with C&E when we added the new requirement 'hide Associated Parcel field even if the document type = Certificate of Title'. Before, I think the Certificate of Title document type always triggered the Associated Parcel to appear.

Expected Behaviour

• From Draft Decision form, upload document -> no 'Associated Parcel' field ever
• From ALCS Document tab:
  • when Type != Certificate of Title, no 'Associated Parcel' field
  • Applications, NOIs, SRWs: when Type = Certificate of Title, 'Associated Parcel' field is present -> the only time
  • Planning Reviews, Inquiries: when Type = Certificate of Title, no 'Associated Parcel' field -> THIS IS A NEW REQUIREMENT, but it's currently doing this, see Actual Behaviour section.
• From C&E chronology, Create file, + Map, Views:
  • no 'Associated Parcel' field ever

Actual Behaviour

• From Draft Decision form, upload document -> 'Associated Parcel' is present -> INCORRECT
• From ALCS Document tab:
  • when Type != Certificate of Title, 'Associated Parcel' field is present -> INCORRECT
  • Applications, NOIs, SRWs: when Type = Certificate of Title, 'Associated Parcel' field is hidden -> INCORRECT
  • Planning Reviews, Inquiries: when Type = Certificate of Title, 'Associated Parcel' field is hidden -> CORRECT, this is the new requirement I mentioned above
• From C&E:
  • Create file > Complaint / Referral upload
    • when Type != Certificate of Title, 'Associated Parcel' field is present -> INCORRECT
    • cannot set Type = Certificate of Title -> CORRECT
  • Create file > Property Ownership Document upload
    • when Type != Certificate of Title, 'Associated Parcel' field is hidden -> CORRECT
    • when Type = Certificate of Title, 'Associated Parcel' field is hidden -> CORRECT
  • Complaint / Referral TAB View > Complaint / Referral upload
    • when Type != Certificate of Title, 'Associated Parcel' field is present -> INCORRECT
    • cannot set Type = Certificate of Title -> CORRECT
  • Property & Maps TAB View > Add Maps
    • when Type != Certificate of Title, 'Associated Parcel' field is present -> INCORRECT
    • cannot set Type = Certificate of Title -> CORRECT
  • Responsible Parties TAB View > Add property ownership documents
    • when Type != Certificate of Title, 'Associated Parcel' field is hidden -> CORRECT
    • when Type = Certificate of Title, 'Associated Parcel' field is hidden -> CORRECT
  • Chronology
    • when Type != Certificate of Title, 'Associated Parcel' field is present -> INCORRECT
    • when Type = Certificate of Title, 'Associated Parcel' field is hidden -> CORRECT
• See snips in the comment below.

Apply fix for:

• Applications: both Draft Decision upload modal and Documents tab upload modal
• NOIs: both Draft Decision upload modal and Documents tab upload modal
• Planning Reviews: both Draft Decision upload modal and Documents tab upload modal
• SRWs: Documents tab upload modal
• Inquiries: Documents tab upload modal
• C&E: Complaint / Referral upload (Create & View), Map upload (View), chronology

[ancharb]

Decision document from decision draft scenario:

Document from Documents tab scenario:

• No Type selection or Type is any other than Certificate of Title

Document from Documents tab scenario

• Type = Certificate of Title for Applications, NOIs, and SRWs

[ancharb]

First QA Pass:

Cannot upload Certificate of Title document in the following places because the save button is disabled:

• C&E Chronology
• Planning Review document
• Inquiry document

ER: User can select Certificate of Title as the document type, the 'Associated Parcel' field does not appear, and they can save the upload

AR:

[ancharb]

Second QA Pass:

Decision document upload modal for Applications, NOIs, and Planning Reviews

E.g. Application > Decision Tab > Draft Decision > Add Document > Upload modal

Associated Parcel field is present when it should not be

• ER: Associated parcel field is not present. Apply fix to Applications, NOIs, and Planning Reviews

....

Will ask devs if this PR was rolled back or something bc I think the original behaviour is back