feat: CE-2095+2145 refresh of datepicker UX and support null/empty times in date picker#1422
Open
jon-funk wants to merge 21 commits intorelease/2.18from
Open
feat: CE-2095+2145 refresh of datepicker UX and support null/empty times in date picker#1422jon-funk wants to merge 21 commits intorelease/2.18from
jon-funk wants to merge 21 commits intorelease/2.18from
Conversation
Co-authored-by: Alec Wilcox <alecwilcox@gmail.com> Co-authored-by: team-wolverine-nrm-repo-updater[bot] <203337993+team-wolverine-nrm-repo-updater[bot]@users.noreply.github.com> Co-authored-by: jon-funk <johnthomasfunk@gmail.com> Co-authored-by: Dmitri <108112696+dk-bcps@users.noreply.github.com>
Co-authored-by: Mike Vesprini <mike@button.is> Co-authored-by: Ryan Rondeau <nayr974@users.noreply.github.com> Co-authored-by: team-wolverine-nrm-repo-updater[bot] <203337993+team-wolverine-nrm-repo-updater[bot]@users.noreply.github.com> Co-authored-by: jon-funk <johnthomasfunk@gmail.com> Co-authored-by: Ryan Rondeau <ryan_rondeau@live.ca> Co-authored-by: Dmitri <108112696+dk-bcps@users.noreply.github.com>
Co-authored-by: Ryan Rondeau <nayr974@users.noreply.github.com> Co-authored-by: Alec Wilcox <alecwilcox@gmail.com> Co-authored-by: team-wolverine-nrm-repo-updater[bot] <203337993+team-wolverine-nrm-repo-updater[bot]@users.noreply.github.com> Co-authored-by: jon-funk <johnthomasfunk@gmail.com> Co-authored-by: Ryan Rondeau <ryan_rondeau@live.ca> Co-authored-by: Dmitri <108112696+dk-bcps@users.noreply.github.com>
jon-funk
changed the title
jon-funk
changed the title
nayr974
requested changes
Feb 18, 2026
| const dateKey = startOfDay(report.actionedTimestamp).toISOString(); | ||
| if (!acc[dateKey]) acc[dateKey] = { date: report.actionedTimestamp, reports: [] }; | ||
| acc[dateKey].reports.push(report); | ||
| const actionedDateTime = (() => { |
Collaborator
There was a problem hiding this comment.
There's a lot of bespoke date time handling in each individual component, can this be moved into a couple utility functions for splitting and combining date parts with logic that can be shared across the app?
|
Collaborator
|
I fixed the build issue, am good with the code, and did some testing that all looked good but I'm now wondering if we need to make changes to handle the WebEOC logic that creates complaints. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contains both changes for the date picker refresh (CE-2095) and allowing null/empty times on certain fields (CE-2145)
Code smell note: https://github.com/bcgov/nr-compliance-enforcement/pull/1422/changes#diff-9f73758bb48ae9ab1535796f060a02352736ceddf7e2ec02ad4e7c48dc17148cR4 has an omit extends as a shim workaround otherwise we'd need to release a new version of https://github.com/bcgov/nr-compliance-enforcement-common/ and impact all dev envs at once OR hand-release and tag a package version dedicated to this PR but we have no release process for that.
The large diff migration-complaint/test-only-migrations/R__data_complaints.sql is from the ordering & splitting change on the complaints table, this required the test-only mig be updated, otherwise fresh dev environments would not succeed with their test data migrations.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: