Fix: warnings in code checker

Author: bdaloukas

bookquiz/play.php

@@ -74,7 +74,7 @@ function game_bookquiz_continue(
  * @param stdClass $course
  */
 function game_bookquiz_play($cm, $game, $attempt, $bookquiz, $chapterid, $context, $course) {
-    global $DB, $OUTPUT, $cm;
+    global $DB, $OUTPUT;
 
     // Find where the book is stoped.
     if ($bookquiz->lastchapterid == 0) {

lib.php

@@ -749,14 +749,14 @@ function game_get_extra_capabilities(): array {
     return $caps;
 }
 
-/*
- * Return a textual summary of the number of attemtps that have been made at a particular game,
+/**
+ * Return a summary of the number of attempts made for a game.
  *
- * @param stdClass $game the game object. Only $game->id is used at the moment.
- * @param stcClass $cm the cm object. Only $cm->course, $cm->groupmode and $cm->groupingid fields are used at the moment.
- * @param bool $returnzero if false (default), when no attempts have been made '' is returned instead of 'Attempts: 0'.
- * @param int $currentgroup if there is a concept of current group pass it in here. Default 0 which means no current group.
- * @return string a string like "Attempts: 123", "Attemtps 123 (45 from your groups)"
+ * @param stdClass $game The game object. Only $game->id is used.
+ * @param stdClass $cm The course module object. Only $cm->course, $cm->groupmode and $cm->groupingid are used.
+ * @param bool $returnzero If false, when no attempts have been made an empty string is returned.
+ * @param int $currentgroup The current group id. Default 0 means no current group.
+ * @return string A summary such as "Attempts: 123".
  */
 function game_num_attempt_summary(stdClass $game, stdClass $cm, bool $returnzero = false, int $currentgroup = 0) {
     global $CFG, $USER, $DB;

showattempts.php

@@ -15,9 +15,10 @@
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
 /**
- * This page shows the answers of the current game
+ * This page shows the answers of the current game.
  *
  * @package    mod_game
+ * @subpackage game
  * @copyright  2007 Vasilis Daloukas
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */

snakes/play.php

@@ -15,11 +15,10 @@
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
 /**
- * Snakes and Ladders game play logic.
- *
- * This file contains all gameplay functions for the snakes game type.
+ * Export game to printable HTML format.
  *
  * @package    mod_game
+ * @subpackage snakes
  * @copyright  2007 Vasilis Daloukas
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */

sudoku/create.php

@@ -34,32 +34,29 @@
 }
 
 /**
- * Show form
+ * Show the form.
  *
  * @package mod_game
  */
 function showform() {
-    $id = required_param('id', PARAM_NUMBER);   // The action.
-
-?>
-<form name="form" method="post" action="create.php">
-<center>
-<table cellpadding="5">
-<tr valign="top">
-    <td align="right"><b><?php  echo get_string('sudoku_create_count', 'game'); ?>:</b></td>
-    <td>
-        <input type="text" name="count" size="6" value="2" /><br>
-    </td>
-</tr>
-<tr><td colspan=2><center><br><input type="submit" value="<?php  print_string('sudoku_create_start', 'game') ?>" /></td></tr>
-</table>
-<input type="hidden" name=action        value="create" >
-<input type="hidden" name=level1        value="1" >
-<input type="hidden" name=level2        value="10" >
-<input type="hidden" name=id        value="<?php  echo $id; ?>" />
-</form>
-
-    <?php
+    $id = required_param('id', PARAM_INT);
+
+    echo '<form name="form" method="post" action="create.php">';
+    echo '<div>';
+    echo '<table cellpadding="5">';
+    echo '<tr valign="top">';
+    echo '<td align="right"><b>' . get_string('sudoku_create_count', 'game') . ':</b></td>';
+    echo '<td><input type="text" name="count" size="6" value="2" /><br></td>';
+    echo '</tr>';
+    echo '<tr><td colspan="2"><center><br><input type="submit" value="' .
+            s(get_string('sudoku_create_start', 'game')) . '" /></center></td></tr>';
+    echo '</table>';
+    echo '<input type="hidden" name="action" value="create" />';
+    echo '<input type="hidden" name="level1" value="1" />';
+    echo '<input type="hidden" name="level2" value="10" />';
+    echo '<input type="hidden" name="id" value="' . s($id) . '" />';
+    echo '</div>';
+    echo '</form>';
 }
 
 /**

sudoku/play.php

@@ -372,19 +372,18 @@ function game_sudoku_showsudoku(
     echo "</table>\r\n";
     $href = $CFG->wwwroot . '/mod/game/attempt.php?action=sudokucheckn&id=' . $cm->id;
 
-?>
-    <script language="javascript">
-        function OnCheck(pos) {
-            s = window.prompt("<?php echo get_string('sudoku_guessnumber', 'game') ?>", "");
-            if (s < "1")
-                return;
-            if (s > "9")
-                return;
-            window.location.href = "<?php echo $href; ?>&pos=" + pos + "&num=" + s;
+    echo '<script type="text/javascript">
+    function OnCheck(pos) {
+        var s = window.prompt(' . json_encode(get_string('sudoku_guessnumber', 'game')) . ', "");
+        if (s < "1") {
+            return;
         }
-    </script>
-    <?php
-
+        if (s > "9") {
+            return;
+        }
+        window.location.href = ' . json_encode($href) . ' + "&pos=" + pos + "&num=" + s;
+    }
+</script>';
     // Here are the congratulations.
     if ($attempt->timefinish) {
         return $count;